Skip to content

perf: add cached CRS variants and benchmarks#2188

Open
Brijesh-gangwar wants to merge 2 commits intofleaflet:masterfrom
Brijesh-gangwar:perf/cache-zoom-scale-crs
Open

perf: add cached CRS variants and benchmarks#2188
Brijesh-gangwar wants to merge 2 commits intofleaflet:masterfrom
Brijesh-gangwar:perf/cache-zoom-scale-crs

Conversation

@Brijesh-gangwar
Copy link
Copy Markdown

fixed #2183

@JaffaKetchup JaffaKetchup requested a review from a team April 13, 2026 20:28
@JaffaKetchup
Copy link
Copy Markdown
Member

Thanks for submitting this! It looks good so far, although we'll need to look into the API just a little more. Sorry it's taken so long to acknowledge!

@Brijesh-gangwar Brijesh-gangwar force-pushed the perf/cache-zoom-scale-crs branch from d10aa08 to 4fd8f05 Compare April 30, 2026 05:15
@Brijesh-gangwar
Copy link
Copy Markdown
Author

@JaffaKetchup Thanks for the review. I’ve addressed your feedback and pushed an update.
PR #2188 failed because Analyze Code reported must_be_immutable in lib/src/geo/crs.dart: cached CRS classes had mutable mixin fields.
Fix in commit b05303e: replaced mutable mixin fields with Expando<_ScaleZoomCache> (external per-instance cache) and added missing constructor docs.
Local result: dart analyze --fatal-infos --fatal-warnings now passes for crs.dart and the immutability issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance improvement with zoom/scale

3 participants