chore: move attestation-provider-server crate from proxy repo#17
Open
steph-rs wants to merge 2 commits intoflashbots:mainfrom
Open
chore: move attestation-provider-server crate from proxy repo#17steph-rs wants to merge 2 commits intoflashbots:mainfrom
steph-rs wants to merge 2 commits intoflashbots:mainfrom
Conversation
ameba23
approved these changes
Apr 3, 2026
Collaborator
ameba23
left a comment
ameba23
left a comment
There was a problem hiding this comment.
Great! Thank you.
Will also get @0x416e746f6e to take a look.
For context, this moves the crate as-is over from the attested-tls-proxy repo, as it is more related to the contents of this repo than to the proxy.
0x416e746f6e
approved these changes
May 7, 2026
Member
0x416e746f6e
left a comment
0x416e746f6e
left a comment
There was a problem hiding this comment.
thanks for this contribution.
small nit: can the provider server be made to fail with error if attestation type detection fails?
Comment on lines
+14
to
+15
| attestation = { path = "../attestation" } | ||
| tokio.workspace = true |
Member
There was a problem hiding this comment.
suggestion:
Suggested change
| attestation = { path = "../attestation" } | |
| tokio.workspace = true | |
| attestation = { workspace = true } | |
| tokio = { workspace = true } |
Member
|
p.s. also, could you please rebase this PR @steph-rs? |
Author
|
yeah, I'll do fixes and rebase in a few days. happy to help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
attestation-provider-servercrate from proxy repo.As discussed in flashbots/attested-tls-proxy#156.
Changes:
attested-tls-proxydependency with directattestationpath dependencytokiofrom workspace dependencies