fix high cpu load in web version #66#78
Open
luginf wants to merge 1 commit intoflagxor:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(sorry @flagxor I've used a LLM for fixing this, here is the report, it seemed to be a legit bug)
Three changes in web/utils.fs:
Exact mirror of the POSIX fix in termios-key: when other tasks are running, cooperate via pause; when
alone, hand control back to the browser via yield.
web-key?: same pause?/yield pattern.
yielding: begin 50 ms yield again → begin pause yield again
This was the main source of the problem: 50 ms loops via pause for 50 real milliseconds at full CPU
before calling yield. With begin pause yield again, the sequence becomes: pause (yields to other tasks)
→ yield (hands control back to the browser) → the browser calls back via setTimeout(run, 0) ~4ms
later. The VM now only runs for a few microseconds per 4ms cycle → near-zero CPU usage.