Migrate most list APIs to failure-resilient streaming utilities#831
Merged
Migrate most list APIs to failure-resilient streaming utilities#831
Conversation
habfast
requested review from
a team,
arthuraliiev,
kobajagi,
natalie-o-perret,
pierre-emmanuelJ and
sauterp
pierre-emmanuelJ
approved these changes
May 5, 2026
| } | ||
| if out[3].Zone != "ch-gva-2" || out[3].Family != "gpu-h100" { | ||
| t.Errorf("expected ch-gva-2/gpu-h100 fourth, got %s/%s", out[3].Zone, out[3].Family) | ||
| for _, r := range rows { |
Contributor
There was a problem hiding this comment.
The mock returns 2 specific entries (gpu-a5000/unauthorized and gpu-a100/authorized) but the test only checks the zone name now.
Since we're in a single-zone mock the order is deterministic, so we could still check the family names and authorized values like the old test did.
natalie-o-perret
approved these changes
May 5, 2026
Contributor
natalie-o-perret
left a comment
natalie-o-perret
left a comment
There was a problem hiding this comment.
In the grand scheme of things, fine by me, just a few nit's here and there.
habfast
force-pushed
the
improve-zone-failure-handling-part2
branch
from
34d4e4e to
ae67be3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #826, finishes sc-177228
Migrated:
Skipped:
Note that the Changelog is already updated from the previous PR! It doesn't need to be touched again
Checklist
Changelog updatedTesting
Manually ran every single command that has been updated against the exoscale-ops organization. Works smoothly.
