Skip to content

Bump and pin the base layer#335

Merged
homersimpsons merged 1 commit into
exercism:mainfrom
IsaacG:bump
May 12, 2026
Merged

Bump and pin the base layer#335
homersimpsons merged 1 commit into
exercism:mainfrom
IsaacG:bump

Conversation

@IsaacG
Copy link
Copy Markdown
Member

@IsaacG IsaacG commented May 11, 2026

This is a good opportunity to bump PHP to 8.5 while we're at it, too. Is that something you'd like to see happen here?

@IsaacG IsaacG requested a review from a team as a code owner May 11, 2026 16:37
@IsaacG IsaacG added x:rep/small Small amount of reputation x:module/representer Work on Representers x:size/small Small amount of work labels May 11, 2026
Copy link
Copy Markdown
Collaborator

@homersimpsons homersimpsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not for nor against pinning here. I believe that supply chain attack risk is rather low here (we do not build those images often and those are well maintained packages).

I would hope that dependabot report new updates.

About PHP8.5 we will upgrade later with the test suite an test runner.

Note that an @exercism/guardians should approve this. @IsaacG I think you are one, I do not know if you can self approve.

@IsaacG
Copy link
Copy Markdown
Member Author

IsaacG commented May 11, 2026

  1. I agree the supply chain risk here is pretty low.
  2. Dependabot can update hashes but it doesn't sync cross-track. If we update every couple of months, a shell script should make it pretty easy to bump hashes uniformly.
  3. I cannt self-approve so I'll need to wait for another @exercism/guardians to help out.

Copy link
Copy Markdown
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@IsaacG
Copy link
Copy Markdown
Member Author

IsaacG commented May 11, 2026

+cc @mk-mxp

@IsaacG
Copy link
Copy Markdown
Member Author

IsaacG commented May 11, 2026

See also exercism/php-test-runner#173

@homersimpsons
Copy link
Copy Markdown
Collaborator

homersimpsons commented May 11, 2026

  1. Dependabot can update hashes but it doesn't sync cross-track. If we update every couple of months, a shell script should make it pretty easy to bump hashes uniformly.

Yes dependabot won't do cross-repo, but it may still open merge requests on every repo.

PHP releases are generally once per year so we can update once a year.

If there is a little (time) desync it should be fine.

@IsaacG
Copy link
Copy Markdown
Member Author

IsaacG commented May 11, 2026

The problem with using Dependabot is that there's no way to ensure it uses the same hash consistently across the various repos. It might update the represented with SHA 123, go off for an hour during which a new SHA can be pushed, then use SHA 456 for the test runner.

@homersimpsons homersimpsons merged commit 0b2b741 into exercism:main May 12, 2026
4 checks passed
@IsaacG IsaacG deleted the bump branch May 12, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:module/representer Work on Representers x:rep/small Small amount of reputation x:size/small Small amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants