Skip to content

Daemon and wallet model maintenance#87

Merged
everoddandeven merged 1 commit intomainfrom
fixes-3
Apr 25, 2026
Merged

Daemon and wallet model maintenance#87
everoddandeven merged 1 commit intomainfrom
fixes-3

Conversation

@everoddandeven
Copy link
Copy Markdown
Owner

  • Implement serializable_struct for extended daemon and wallet model
  • Use listener reference in monero_daemon_rpc
  • Refactory PyMoneroUtils::make_uri, PyMoneroUtils::get_payment_uri
  • Refactory test code

* Implement serializable_struct for extended daemon and wallet model
* Use listener reference in monero_daemon_rpc
* Refactory PyMoneroUtils::make_uri, PyMoneroUtils::get_payment_uri
* Refactory test code
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 25, 2026

Not up to standards ⛔

🔴 Issues 6 medium · 1 minor

Alerts:
⚠ 7 issues (≤ 0 issues of at least minor severity)

Results:
7 new issues

Category Results
CodeStyle 1 minor
Complexity 6 medium

View in Codacy

🟢 Metrics 181 complexity · 10 duplication

Metric Results
Complexity 181
Duplication 10

View in Codacy

🟢 Coverage 88.07% diff coverage · +0.15% coverage variation

Metric Results
Coverage variation +0.15% coverage variation (-1.00%)
Diff coverage 88.07% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (870ba3f) 17569 15819 90.04%
Head commit (d7a4af0) 17865 (+296) 16113 (+294) 90.19% (+0.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#87) 729 642 88.07%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@everoddandeven everoddandeven merged commit 921eabf into main Apr 25, 2026
6 checks passed
@everoddandeven everoddandeven deleted the fixes-3 branch April 25, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant