Merged
Conversation
Switch the `test` job's Python dependency install to the recipe form `uv pip install --system -r app/requirements.txt`, dropping the redundant `uv venv .venv` + `$GITHUB_PATH` plumbing now that deps land on the system interpreter directly. Pin the adjacent `astral-sh/setup-uv` to `08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0` to match the hardening style. The `lint-and-format` and `security-scan` jobs already use `astral-sh/setup-uv@v7` and are left untouched (no `pip install` to swap there). Out of scope: `Makefile` `install-tools` target, which already invokes `uv tool install` for the Python toolchain. Cross-references the resilience pattern landed in evalops/maestro-internal#1492. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PR SummaryLow Risk Overview Pins Reviewed by Cursor Bugbot for commit 1af0e79. Bugbot is set up for automated code reviews on this repo. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testjob in.github/workflows/ci.yml: collapseuv venv .venv+$GITHUB_PATHecho +uv pip install -r app/requirements.txtinto the recipe formuv pip install --system -r app/requirements.txt.astral-sh/setup-uv(line 85 of the original) to08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0.lint-and-formatandsecurity-scanjobs unchanged — they have nopip installto swap and their existingastral-sh/setup-uv@v7references are out of scope for this PR.Why
Aligns the
testjob's Python install with the resilience pattern landed in evalops/maestro-internal#1492 (uv resumes partial downloads + retries on connection drops, removing the pip read-timeout flake class).Scope
.github/only. TheMakefileinstall-toolstarget — which already invokesuv tool install black/flake8/isort/mypyanduv pip install -r app/requirements.txt— is intentionally out of scope here.UV_HTTP_TIMEOUT=120wrapper from #1492 is not used in this diff.Test plan
testjob installs deps viauv pip install --system -r app/requirements.txt, thenmake install-tools, thenmake testagainst the postgres service).make install-tools' downstreamuv pip install -r app/requirements.txt(Makefile:126) still completes — it now installs into system Python rather than the previously-active.venv.🤖 Generated with Claude Code