feat(ci): add integration tests for AutoTLS in Beekeeper workflow#5350
Open
akrem-chabchoub wants to merge 33 commits intomasterfrom
Open
feat(ci): add integration tests for AutoTLS in Beekeeper workflow#5350akrem-chabchoub wants to merge 33 commits intomasterfrom
akrem-chabchoub wants to merge 33 commits intomasterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
akrem-chabchoub
requested review from
acud,
gacevicljubisa,
janos and
martinconic
martinconic
approved these changes
Feb 16, 2026
| - name: Collect debug artifacts | ||
| if: failure() | ||
| - name: Collect debug artifacts (local-dns) | ||
| if: failure() && (steps.pingpong.outcome == 'failure' || steps.fullconnectivity.outcome == 'failure' || steps.settlements.outcome == 'failure' || steps.pss.outcome == 'failure' || steps.soc.outcome == 'failure' || steps.gsoc.outcome == 'failure' || steps.pushsync-chunks-1.outcome == 'failure' || steps.pushsync-chunks-2.outcome == 'failure' || steps.retrieval.outcome == 'failure' || steps.manifest.outcome == 'failure' || steps.manifest-v1.outcome == 'failure' || steps.postage-stamps.outcome == 'failure' || steps.stake.outcome == 'failure' || steps.withdraw.outcome == 'failure' || steps.redundancy.outcome == 'failure' || steps.act.outcome == 'failure' || steps.feeds.outcome == 'failure' || steps.feeds-v1.outcome == 'failure') |
Member
There was a problem hiding this comment.
this line are super long, can we just use if: failure()?
| curl -sSf -X POST -H "Content-Type: application/json" -d "{\"text\": \"**${RUN_TYPE}** Beekeeper Autotls Error\nBranch: \`${{ github.head_ref }}\`\nUser: @${{ github.event.pull_request.user.login }}\nDebugging artifacts: [click](https://$BUCKET_NAME.$AWS_ENDPOINT/artifacts_$VERTAG.tar.gz)\nStep failed: \`${FAILED}\`\"}" https://beehive.ethswarm.org/hooks/${{ secrets.TUNSHELL_KEY }} | ||
| echo "Failed test: ${FAILED}" | ||
| - uses: actions/upload-artifact@v4 | ||
| if: failure() && (steps.pingpong-autotls.outcome == 'failure' || steps.fullconnectivity-autotls.outcome == 'failure' || steps.retrieval-autotls.outcome == 'failure' || steps.autotls.outcome == 'failure') |
Contributor
Author
There was a problem hiding this comment.
Agreed, simplifying to if: failure() is much more readable.
One small tradeoff worth noting: if a local-dns test fails, failure() will also trigger the local-dns-autotls artifact collection and notification, even though autotls tests were just skipped (not failed).
So we could get a misleading alert when the actual issue was in local-dns.
…/autotls-integration-test
Removed multiple test steps from the Beekeeper workflow to streamline checks.
Increased the Pebble certificate validity period from 300 to 600.
akrem-chabchoub
force-pushed
the
feat/autotls-integration-test
branch
from
dd94479 to
e31b93b
Compare
gacevicljubisa
approved these changes
Apr 30, 2026
Member
gacevicljubisa
left a comment
gacevicljubisa
left a comment
There was a problem hiding this comment.
Our current AutoTLS check is around 10 min because of the cert auto renewal logic.
We can consider redecing the check time...
martinconic
reviewed
May 4, 2026
| export FAILED='no-test' | ||
| if ${{ steps.pingpong.outcome=='failure' }}; then FAILED=pingpong; fi | ||
| if ${{ steps.fullconnectivity.outcome=='failure' }}; then FAILED=fullconnectivity; fi | ||
| if ${{ steps.settlements.outcome=='failure' }}; then FAILED=settlements; fi |
Contributor
There was a problem hiding this comment.
Why did you deleted this ones, they are still defined further up, right? If any of them fails, the Slack notification will say something like: Step failed: \no-test`` instead of naming the actual failing test, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
local-dns-autotlscluster.Why this is needed
AutoTLS and WSS support are currently being validated on dedicated Beelocal and Beekeeper feature branches.
The existing CI only covered the standard
local-dnscluster and does not exercise the AutoTLS setup.This change allows the CI pipeline to:
Files changed
.github/workflows/beekeeper.ymlOpen API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):