fix(core): add synchronization for race conditions#101
Merged
Conversation
encodeous
force-pushed
the
ac/spring-clean-26
branch
2 times, most recently
from
a4c3373 to
61223da
Compare
Due to the addition of hot-reloading config, and the realization in #99, nylon has many sections of code which exhibit race conditions. This PR tries to address some of the obvious race conditions.
encodeous
force-pushed
the
ac/spring-clean-26
branch
from
61223da to
bdd42dd
Compare
encodeous
force-pushed
the
ac/spring-clean-26
branch
from
58541f8 to
ee87d71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the addition of hot-reloading config, and the realization in #99, nylon has many sections of code which exhibit race conditions.
This PR tries to address some of the obvious race conditions.