Fix browser.test_audioworklet_worker instability on Chrome#26841
Open
juj wants to merge 1 commit intoemscripten-core:mainfrom
Open
Fix browser.test_audioworklet_worker instability on Chrome#26841juj wants to merge 1 commit intoemscripten-core:mainfrom
juj wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
juj
force-pushed
the
fix_chrome_worker_start_hang
branch
from
1460e63 to
d2b0d11
Compare
…s some kind of network throttling mechanism, which prevents the Wasm Worker from being able to start up in the test browser.test_audioworklet_worker. There is no reason to keep fetching /check every 10 milliseconds (except for performance). Reduce the fetch interval to a much more modest rate of 5 fetches per second. The browser test suite has ~150 tests, so this can slow down the test harness by at most 30 seconds.
juj
force-pushed
the
fix_chrome_worker_start_hang
branch
from
d2b0d11 to
7ae80a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix browser.test_audioworklet_worker instability on Chrome.
Chrome has some kind of network throttling mechanism, which prevents the Wasm Worker from being able to start up in the test browser.test_audioworklet_worker.
There is no reason to keep fetching /check every 10 milliseconds (except for performance). Reduce the fetch interval to a more modest rate of 5 fetches per second.
The browser test suite has ~150 tests, so this can slow down the test harness by at most 30 seconds.