Increase stack size in test browser.test_audioworklet_worker to 4KB#26837
Merged
juj merged 1 commit intoemscripten-core:mainfrom May 2, 2026
Merged
Conversation
…to fit emscripten_outf() call.
Collaborator
Author
|
This was already approved in review as part of #26835 so I'll land this in. |
Collaborator
Author
|
After fixing the problem #26823 with this PR, the test began to work correctly in Firefox, but surprisingly, it now fails in Chrome. When CircleCI ran the browser tests in Chrome as part of this PR, the suite came out green: 
But (TIL) there is another CircleCI task that runs on the 
(failing on There is a race condition problem in the test. I posted PR #26839 to address that. I see that test is now green on CircleCI, so maybe that fixes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase stack size in test browser.test_audioworklet_worker to 4KB, to fit emscripten_outf() call in the Worker.