Run test_wasm_worker_futex_wait also in hybrid mode. NFC#26827
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Run test_wasm_worker_futex_wait also in hybrid mode. NFC#26827sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
test_wasm_worker_futex_wait also in hybrid mode. NFC#26827sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
futex_wait_pthread_wasm_workers
branch
from
c8f3359 to
bbd207c
Compare
sbc100
force-pushed
the
futex_wait_pthread_wasm_workers
branch
2 times, most recently
from
557f2cd to
288bac7
Compare
Collaborator
Author
|
Let me know if you want to split out the decorator move/expand as an NFC |
sbc100
force-pushed
the
futex_wait_pthread_wasm_workers
branch
from
288bac7 to
83d6291
Compare
kripken
reviewed
Apr 30, 2026
| @wraps(f) | ||
| def decorated(self, threads, *args, **kwargs): | ||
| if threads: | ||
| self.cflags += ['-pthread'] |
Member
There was a problem hiding this comment.
Should this also do require_pthreads()?
Member
There was a problem hiding this comment.
(some of the code replaced did that)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.