Add SYCL support by allnes · Pull Request #284 · embedded-dev-research/ITLabAI

allnes · 2026-03-17T15:04:58Z

No description provided.

codecov · 2026-03-17T18:33:17Z

Codecov Report

❌ Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.13%. Comparing base (60c1097) to head (ee17d26).

Files with missing lines	Patch %	Lines
include/parallel/backends.hpp	75.00%	0 Missing and 4 partials ⚠️

❗ There is a different number of reports uploaded between BASE (60c1097) and HEAD (ee17d26). Click for more details.

HEAD has 2 uploads less than BASE

Flag BASE (60c1097) HEAD (ee17d26)

4 2

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #284       +/-   ##
===========================================
- Coverage   84.69%   66.13%   -18.57%     
===========================================
  Files          61       61               
  Lines        3744     4665      +921     
  Branches     2218     2560      +342     
===========================================
- Hits         3171     3085       -86     
- Misses        285      331       +46     
- Partials      288     1249      +961

Flag	Coverage Δ
sycl	`61.75% <82.35%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aobolensk

Please, simplify the scripts. They are overcomplicated for what they are aiming to do

aobolensk · 2026-03-17T18:18:42Z

      run: |
-        clang-tidy app/**/*.cpp src/**/*.cpp -format-style=file -header-filter="($PWD/include/.*|$PWD/src/.*|$PWD/app/.*)" -p build
+        mapfile -t files < <(find app src -name '*.cpp' ! -path 'app/SYCL/*' | sort)
+        clang-tidy "${files[@]}" -format-style=file -header-filter="($PWD/include/.*|$PWD/src/.*|$PWD/app/.*)" -p build


Use .clang-tidy file in app/SYCL instead

It seems this comment was not addressed

aobolensk · 2026-03-17T18:21:17Z

+    target_compile_definitions(run_test PRIVATE _CRT_SECURE_NO_WARNINGS)
+


Can we avoid it?

aobolensk · 2026-03-17T18:22:24Z

+option(ITLABAI_ENABLE_OPENMP "Enable OpenMP parallel support" ON)
+option(ITLABAI_ENABLE_OPENCV_APPS "Build OpenCV-dependent apps" ON)
+option(ITLABAI_BUILD_TESTS "Build unit tests" ON)
+set(ITLABAI_OPENCV_DIR "" CACHE PATH
+    "Path to a prebuilt OpenCV package directory containing OpenCVConfig.cmake")
+set(ITLABAI_TBB_DIR "" CACHE PATH
+    "Path to a prebuilt oneTBB package root containing lib/cmake/tbb/TBBConfig.cmake")
+set(ITLABAI_SYCL_TARGETS "" CACHE STRING
+    "Optional SYCL targets passed to -fsycl-targets")


Can we also not include this to this PR?

aobolensk · 2026-03-17T18:23:35Z

+env:
+  INTEL_LLVM_TAG: v6.3.0
+  OPENCV_TAG: 4.13.0
+  TBB_TAG: v2022.3.0


Is it possible to reuse our TBB?

aobolensk · 2026-03-17T18:23:40Z

+
+env:
+  INTEL_LLVM_TAG: v6.3.0
+  OPENCV_TAG: 4.13.0


Same for OpenCV

aobolensk · 2026-03-17T18:37:34Z

+target_compile_options(SYCL_Example PRIVATE
+    $<$<COMPILE_LANG_AND_ID:CXX,Clang>:-Wno-unused-parameter>
+)
+set_property(SOURCE sycl_example.cpp APPEND PROPERTY COMPILE_OPTIONS
+    $<$<COMPILE_LANG_AND_ID:CXX,Clang>:-Wno-deprecated-declarations>
+)
+set_property(SOURCE sycl_example.cpp APPEND PROPERTY COMPILE_DEFINITIONS
+    SYCL_DISABLE_FSYCL_SYCLHPP_WARNING=1
+)


Not needed. -Wno-error for the app would be even better

aobolensk · 2026-03-17T18:37:47Z

+    $<TARGET_PROPERTY:itlabai_sycl,INTERFACE_COMPILE_OPTIONS>
+    $<$<COMPILE_LANG_AND_ID:CXX,Clang>:-Wno-unused-parameter>
+    $<$<AND:$<COMPILE_LANG_AND_ID:CXX,Clang>,$<PLATFORM_ID:Linux>,$<CONFIG:Debug>>:-O2>
+    $<$<AND:$<COMPILE_LANG_AND_ID:CXX,Clang>,$<PLATFORM_ID:Linux>,$<CONFIG:Debug>>:-g0>


Is this complication justified?

aobolensk · 2026-03-17T18:38:29Z

+void rethrow_async_exceptions(sycl::exception_list exceptions) {
+  for (const std::exception_ptr& exception : exceptions) {
+    std::rethrow_exception(exception);
+  }
+}


Just do not pass this param

aobolensk · 2026-03-17T18:41:10Z

 // returns time in seconds
 template <class Function, typename... Args>
 double elapsed_time_omp(Function&& func, Args&&... args) {
+#if defined(HAS_OPENMP)


Please, remove

aobolensk · 2026-03-17T18:41:57Z

                     const Options& opt) {
+  static_cast<void>(opt);


Use maybe_unused attribute here

aobolensk · 2026-03-26T13:30:56Z

@@ -1,12 +1,14 @@
 #pragma once
+// clang-format off


what is that for?

aobolensk · 2026-03-26T13:31:05Z

 }

-#ifdef HAS_OPENMP
+#ifdef _OPENMP


Please, revert

aobolensk · 2026-03-26T13:31:12Z

 namespace parallel {

-enum class Backend : std::uint8_t {
+enum class Backend : uint8_t {


Also, please revert

aobolensk · 2026-03-26T13:32:19Z

Please, remove all unnecessary changes (since we don't have checks for all platforms). Ideally, that should be one very simple script with < 100 LoC

aobolensk · 2026-03-26T13:32:29Z

why it was removed?

aobolensk · 2026-03-26T13:32:42Z

@@ -1,4 +1,5 @@
-#include <cstdint>
+#include <stdint.h>


Same and everywhere else. Why?

aobolensk · 2026-03-26T18:20:08Z

    - name: Run clang-tidy
      run: |
-        clang-tidy app/**/*.cpp src/**/*.cpp -format-style=file -header-filter="($PWD/include/.*|$PWD/src/.*|$PWD/app/.*)" -p build
+        python3 - <<'PY'


There should be no changes. app/SYCL can contain exclusions

aobolensk · 2026-03-27T14:15:31Z

    - name: Run clang-tidy
      run: |
-        clang-tidy app/**/*.cpp src/**/*.cpp -format-style=file -header-filter="($PWD/include/.*|$PWD/src/.*|$PWD/app/.*)" -p build
+        mapfile -t sources < <(find app src -path 'app/SYCL' -prune -o -name '*.cpp' -print)


Still not addressed

aobolensk · 2026-03-27T14:17:48Z

            concat_connections[layer_name].push_back(base_input_name);
          }
        }
-        auto concat_layer = LayerFactory::createConcatLayer(axis, options);


Please, revert

aobolensk · 2026-03-27T14:17:56Z

 #include "layers/Tensor.hpp"
 #include "layers/TransposeLayer.hpp"
 #include "layers_oneDNN/BinaryOpLayer.hpp"
-#include "layers_oneDNN/ConcatLayer.hpp"


Please, revert

aobolensk · 2026-03-27T14:18:33Z

@@ -1,30 +1,216 @@
+include(ExternalProject)


These changes also should've not been popped out

aobolensk · 2026-03-27T14:18:45Z

@@ -1,5 +1,5 @@
 #pragma once
-#include <cstdint>
+#include <stdint.h>


Still not addressed

allnes · 2026-05-03T23:22:46Z

@aobolensk please review

aobolensk

LGTM

allnes requested a review from aobolensk as a code owner March 17, 2026 15:04

allnes requested a review from AndreySorokin7 March 17, 2026 15:40

aobolensk reviewed Mar 17, 2026

View reviewed changes

allnes requested a review from aobolensk March 26, 2026 13:27

aobolensk reviewed Mar 26, 2026

View reviewed changes

aobolensk reviewed Mar 27, 2026

View reviewed changes

allnes force-pushed the an/sycl-integration branch from 8aae86a to 218b148 Compare April 20, 2026 14:53

Add SYCL backend integration

883f1ba

allnes force-pushed the an/sycl-integration branch from dce1126 to 883f1ba Compare May 1, 2026 20:48

allnes added 8 commits May 2, 2026 10:05

Auto-enable SYCL when AdaptiveCpp is available

d779a3d

Fix Windows SYCL OpenCV build with clang-cl

6365100

Fix SYCL static analysis issues

9a468ec

Limit CI push trigger to main

750e0df

Add SYCL coverage upload

8a4fd68

Fix SYCL coverage reporting

bcdc273

Wait for SYCL coverage upload

ee17d26

Keep regular coverage upload complete

b95d518

allnes requested a review from aobolensk May 3, 2026 23:22

aobolensk approved these changes May 4, 2026

View reviewed changes

allnes merged commit 2136eb1 into embedded-dev-research:main May 4, 2026
28 checks passed

		target_compile_definitions(run_test PRIVATE _CRT_SECURE_NO_WARNINGS)

Conversation

allnes commented Mar 17, 2026

Uh oh!

codecov Bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aobolensk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allnes commented May 3, 2026

Uh oh!

aobolensk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Mar 17, 2026 •

edited

Loading