Skip to content

Fix invalid JSON escape \s in Buildkite trigger comment regexes#3330

Merged
Mpdreamz merged 1 commit intomasterfrom
fix/buildkite-json-invalid-escape
May 3, 2026
Merged

Fix invalid JSON escape \s in Buildkite trigger comment regexes#3330
Mpdreamz merged 1 commit intomasterfrom
fix/buildkite-json-invalid-escape

Conversation

@Mpdreamz
Copy link
Copy Markdown
Member

@Mpdreamz Mpdreamz commented May 3, 2026

Summary

  • Commit 59dffc8 introduced \s into JSON string values in .buildkite/pull-requests.org-wide.json, but \s is not a valid JSON escape sequence
  • This caused a JSONDecodeError on parse, preventing Buildkite from reading the pipeline config at all — no builds were triggering on any PR
  • Fix replaces all 6 occurrences of \s with \\s (the correct way to embed a regex \s inside a JSON string)

Unblocks #3328 and #3329.

Test plan

  • JSON parses cleanly: python3 -c "import json; json.load(open('.buildkite/pull-requests.org-wide.json'))"
  • After merge, verify a commit or run docs-build comment on a PR triggers a Buildkite build

🤖 Generated with Claude Code

\s is not a valid JSON escape sequence, causing a JSONDecodeError that
prevented Buildkite from parsing the pipeline config entirely. No builds
were triggering on any PR as a result. Replace \s with \\s throughout.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@Mpdreamz Mpdreamz requested a review from a team as a code owner May 3, 2026 16:53
@Mpdreamz Mpdreamz requested a review from reakaleek May 3, 2026 16:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@Mpdreamz Mpdreamz enabled auto-merge (squash) May 3, 2026 16:59
@Mpdreamz Mpdreamz merged commit a711d7a into master May 3, 2026
4 checks passed
@Mpdreamz Mpdreamz deleted the fix/buildkite-json-invalid-escape branch May 3, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants