feat(cli,feeds): smart rewrites merge and generic xml handler#745
Open
feat(cli,feeds): smart rewrites merge and generic xml handler#745
Conversation
CLI: when store conf/firebase.json defines a rewrite for a function already present in base config, the merge replaces that entry instead of appending a duplicate. Falls back to adding a new entry if function is not found in base rewrites. Feeds: catalog handler now matches any .xml path (except sitemap), so store-specific routing prefixes work without code changes.
leomp12
reviewed
Apr 24, 2026
| await proxyGithubApi(req, res); | ||
| break; | ||
| } | ||
| if (req.path.endsWith('.xml')) { |
Member
There was a problem hiding this comment.
Suggested change
| if (req.path.endsWith('.xml')) { | |
| if (req.path.endsWith('/catalog.xml')) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI: when store conf/firebase.json defines a rewrite for a function already present in base config, the merge replaces that entry instead of appending a duplicate. Falls back to adding a new entry if function is not found in base rewrites.
Feeds: catalog handler now matches any .xml path (except sitemap), so store-specific routing prefixes work without code changes.