Fix GET /shells?assetIds: multiple globalAssetId values silently returned empty results#512
Merged
s-heppner merged 3 commits intoMay 18, 2026
Conversation
…lts for 2+ globalAssetId filters
Member
|
Can resolve the conflicts on this PR please? |
Keep both tests: test_multiple_global_asset_ids_returns_matching_results (PR fix) and test_malformed_asset_id_missing_field_returns_400 (from develop). Use shared BASE_PATH constant for both.
s-heppner
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500
Changes
len(global_asset_ids) <= 1guard in_get_shells: when 2+globalAssetIdvalues were passed the condition was alwaysFalse, returning HTTP 200 with an empty listassetIdsas a list — OR-matching againstglobal_asset_id in global_asset_idsis the correct behaviortest_multiple_global_asset_ids_returns_matching_resultsunit test