Open
Conversation
…eact into jialecl/timeComponent
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
PelayoFelgueroso
requested changes
Apr 29, 2026
PelayoFelgueroso
requested changes
Apr 30, 2026
Co-authored-by: Copilot <copilot@github.com>
| title: "General", | ||
| content: ( | ||
| <DxcBulletedList> | ||
| <DxcBulletedList.Item> |
Collaborator
There was a problem hiding this comment.
The last phrase doesn't appear on the design
PelayoFelgueroso
requested changes
Apr 30, 2026
| @@ -1,6 +1,6 @@ | |||
| /// <reference types="next" /> | |||
| /// <reference types="next/image-types/global" /> | |||
| import "./.next/types/routes.d.ts"; | |||
Collaborator
There was a problem hiding this comment.
I don't think we should merge this change
raquelarrojo
requested changes
Apr 30, 2026
- Refactor TimeInput to remove isControlled ref and instead directly check if value is undefined. - Add timeFormat to useEffect dependencies to ensure day period updates correctly when time format changes. - Changed undefined values in events to empty strings.
PelayoFelgueroso
previously approved these changes
Apr 30, 2026
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.