Skip to content

[integration/peerlab] feature: adding a reference gene correlation#32

Open
ananya-nandula wants to merge 4 commits intointegration/peerlabfrom
feature/shared-sample-gene-corr-reference
Open

[integration/peerlab] feature: adding a reference gene correlation#32
ananya-nandula wants to merge 4 commits intointegration/peerlabfrom
feature/shared-sample-gene-corr-reference

Conversation

@ananya-nandula
Copy link
Copy Markdown
Collaborator

@ananya-nandula ananya-nandula commented Apr 16, 2026

[WIP]

@Tobiaspk
Copy link
Copy Markdown
Collaborator

Good PR.

Here's what should be changed before we can merge:

  • Don't test if norm is a layer. Instead, ensure that inputs are raw counts and normalise the same way as anndata
  • Add a parameter fill_missing_gene_correlations (or similar) to ignore errors when genes are missing in the reference
  • Remove "# ADDED" and "# NEWLY ADDED" comments. Instead, add those in the PR description.

Creating some tests now to double check these changes

@Tobiaspk Tobiaspk changed the title feature: adding a reference gene correlation [integration/peerlab] feature: adding a reference gene correlation Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants