Skip to content

[aw] Align Code Radiator base-branch policy with safe-output glob matching#25440

Open
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-code-radiator-failure
Open

[aw] Align Code Radiator base-branch policy with safe-output glob matching#25440
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-code-radiator-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

Code Radiator was failing in safe_outputs when processing create_pull_request for xcode26.5, causing code-push output cancellation and masking subsequent missing_tool reporting. The root issue was branch-allowlist pattern semantics not matching runtime glob behavior.

  • Safe-output base branch policy update

    • Updated safe-outputs.create-pull-request.allowed-base-branches in .github/workflows/code-radiator.md to runtime-compatible globs:
      • net*.0
      • xcode*
      • xcode*.*
    • This preserves support for both major-only and dotted Xcode branches (for example xcode26 and xcode26.5).
  • Workflow lock regeneration

    • Recompiled .github/workflows/code-radiator.lock.yml so generated create_pull_request.allowed_base_branches matches source frontmatter.
  • Prompt/body pattern alignment

    • Updated the workflow’s documented “Target Branch Patterns” in the markdown body to match the same glob set and avoid config/prompt drift.
safe-outputs:
  create-pull-request:
    allowed-base-branches:
      - "net*.0"
      - "xcode*"
      - "xcode*.*"

Copilot AI linked an issue May 15, 2026 that may be closed by this pull request
Agent-Logs-Url: https://github.com/dotnet/macios/sessions/4d38f025-6d29-407e-b379-3d2fa0991e27

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code radiator failing on workflow [aw] Align Code Radiator base-branch policy with safe-output glob matching May 15, 2026
Copilot AI requested a review from rolfbjarne May 15, 2026 08:10
@rolfbjarne rolfbjarne marked this pull request as ready for review May 15, 2026 08:54
Copilot AI review requested due to automatic review settings May 15, 2026 08:54
@rolfbjarne rolfbjarne enabled auto-merge (squash) May 15, 2026 08:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns Code Radiator's allowed-base-branches policy with the runtime glob matcher used by safe-outputs, fixing failures when creating PRs against branches like xcode26.5. Patterns shift from character-class regex-ish forms (net[0-9]*.0, etc.) to simple globs (net*.0, xcode*, xcode*.*), and the lock file is regenerated.

Changes:

  • Update allowed-base-branches and documented "Target Branch Patterns" in code-radiator.md to glob form.
  • Regenerate code-radiator.lock.yml so embedded safe-outputs config matches the new frontmatter.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/code-radiator.md Switch frontmatter and prompt-body patterns to net*.0, xcode*, xcode*.*.
.github/workflows/code-radiator.lock.yml Recompiled lock file reflecting the new allowed-base-branches and updated frontmatter hash/heredoc markers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Code Radiator failed

3 participants