[aw] Align Code Radiator base-branch policy with safe-output glob matching#25440
Open
Copilot wants to merge 2 commits into
Open
[aw] Align Code Radiator base-branch policy with safe-output glob matching#25440Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/dotnet/macios/sessions/4d38f025-6d29-407e-b379-3d2fa0991e27 Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code radiator failing on workflow
[aw] Align Code Radiator base-branch policy with safe-output glob matching
May 15, 2026
rolfbjarne
approved these changes
May 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns Code Radiator's allowed-base-branches policy with the runtime glob matcher used by safe-outputs, fixing failures when creating PRs against branches like xcode26.5. Patterns shift from character-class regex-ish forms (net[0-9]*.0, etc.) to simple globs (net*.0, xcode*, xcode*.*), and the lock file is regenerated.
Changes:
- Update
allowed-base-branchesand documented "Target Branch Patterns" incode-radiator.mdto glob form. - Regenerate
code-radiator.lock.ymlso embedded safe-outputs config matches the new frontmatter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/code-radiator.md | Switch frontmatter and prompt-body patterns to net*.0, xcode*, xcode*.*. |
| .github/workflows/code-radiator.lock.yml | Recompiled lock file reflecting the new allowed-base-branches and updated frontmatter hash/heredoc markers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Radiator was failing in
safe_outputswhen processingcreate_pull_requestforxcode26.5, causing code-push output cancellation and masking subsequentmissing_toolreporting. The root issue was branch-allowlist pattern semantics not matching runtime glob behavior.Safe-output base branch policy update
safe-outputs.create-pull-request.allowed-base-branchesin.github/workflows/code-radiator.mdto runtime-compatible globs:net*.0xcode*xcode*.*xcode26andxcode26.5).Workflow lock regeneration
.github/workflows/code-radiator.lock.ymlso generatedcreate_pull_request.allowed_base_branchesmatches source frontmatter.Prompt/body pattern alignment