[tools] Fix marking generated block code when not using any of the static registrars by rolfbjarne · Pull Request #25434 · dotnet/macios

rolfbjarne · 2026-05-14T17:20:50Z

Fix an issue where the new style of generated block supporting code wasn't properly handled by the trimmer when using the dynamic registrar.
Add a 'link sdk' + 'link all' test variation for all platforms for monotouch-test.
Update a few tests to cope with the additional trimming variations for monotouch-test.

…forms for monotouch-test.

Copilot

Pull request overview

This PR extends the xharness Jenkins test matrix for monotouch-test by introducing additional linker coverage across all platforms, adding explicit Link SDK and Link All runs (as Release variations). This fits into the tests/xharness infrastructure that defines how CI expands a single test project into multiple build/run configurations.

Changes:

Add Release|LinkSdk variation for monotouch-test.
Add Release|LinkAll variation for monotouch-test.

Use IsLinkAny instead of IsLinkAll for trimming guards, since SDK-level trimming (linksdk) can also remove framework references, properties, and delegate mismatch checking code from SDK assemblies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The PreserveBlockCodeStep only handled old-style block proxy types (with a Handler field and [MonoPInvokeCallback] attribute on Invoke). New-style block proxy types use [UnmanagedCallersOnly] on Invoke with no Handler field. When using linkall + dynamic registrar (the default on iOS simulator), the existing MarkForStaticRegistrar[Step] does not run (gated on RegistrarMode.Static), so the Invoke method was trimmed. At runtime, the reflection lookup in Blocks.GetBlockForDelegate would then fail with MX8060. Extend PreserveBlockCodeStep to also detect and preserve new-style block proxy Invoke methods, matching on [UnmanagedCallersOnly] and [UserDelegateType] attributes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2026-05-18T16:40:50Z

✅ [PR Build #9437415] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 9437415fb792725262b625210a6ddafb8d195f57 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-18T16:47:07Z

✅ [PR Build #9437415] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 9437415fb792725262b625210a6ddafb8d195f57 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-18T16:53:55Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 9437415fb792725262b625210a6ddafb8d195f57 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-18T17:02:14Z

✅ [PR Build #9437415] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 9437415fb792725262b625210a6ddafb8d195f57 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-18T18:07:21Z

🔥 [CI Build #9437415] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 182 tests passed.

Failures

❌ monotouch tests (macOS)

1 tests failed, 19 tests passed.

Failed tests

monotouch-test/macOS/Release (link all): Failed (Test run failed.
Tests run: 3709 Passed: 3597 Inconclusive: 4 Failed: 3 Ignored: 109)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. (⚠️ Html Report Publish failed ⚠️) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 18 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 9437415fb792725262b625210a6ddafb8d195f57 [PR build]

[xharness] Add a 'link sdk' + 'link all' test variations for all plat…

4d8061a

…forms for monotouch-test.

rolfbjarne requested a review from Copilot May 14, 2026 17:20

rolfbjarne added the copilot label May 14, 2026

Copilot started reviewing on behalf of rolfbjarne May 14, 2026 17:21 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

This was referenced May 18, 2026

[CI Postmortem] Widespread LaunchTimedOut failures on iOS/tvOS simulator tests #25299

Open

[CI Postmortem] Flaky: Xamarin.Mac tests — DerivedEventTest, EveryFrameworkSmokeTests, NSViewTests #25445

Closed

rolfbjarne and others added 3 commits May 18, 2026 13:47

Delete old NuGet.config feeds.

b25e37f

Adjust test to cope for new configuration.

81c5280

rolfbjarne force-pushed the dev/rolf/tests-linked-monotouch-test branch from 74a2acf to 81c5280 Compare May 18, 2026 11:47

rolfbjarne changed the title ~~[xharness] Add a 'link sdk' + 'link all' test variations for all platforms for monotouch-test.~~ [tools] Fix marking generated block code when not using any of the static registrars May 18, 2026

rolfbjarne marked this pull request as ready for review May 18, 2026 12:02

This comment has been minimized.

Sign in to view

dalexsoto approved these changes May 18, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/tests-linked-monotouch-test

55866f5

This comment has been minimized.

Sign in to view

Widen the net.

9437415

rolfbjarne enabled auto-merge (squash) May 18, 2026 16:24

This comment has been minimized.

Sign in to view

Conversation

rolfbjarne commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 18, 2026

✅ [PR Build #9437415] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 18, 2026

✅ [PR Build #9437415] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 18, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 18, 2026

✅ [PR Build #9437415] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 18, 2026

🔥 [CI Build #9437415] Test results 🔥

Test results

Failures

❌ monotouch tests (macOS)

Failed tests

Successes

macOS tests

Linux Build Verification

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rolfbjarne commented May 14, 2026 •

edited

Loading