[net11.0] [dotnet-linker] Add a trimmer step to inline calls to Class.GetHandle[Intrinsic].#25422
Draft
rolfbjarne wants to merge 72 commits into
Draft
[net11.0] [dotnet-linker] Add a trimmer step to inline calls to Class.GetHandle[Intrinsic].#25422rolfbjarne wants to merge 72 commits into
rolfbjarne wants to merge 72 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…nvokes and fix UnscheduleFromRunLoop bug (#25103) - Add [SupportedOSPlatform("macos")] and [ObsoletedOSPlatform("macos13.0")] to FSEventStreamScheduleWithRunLoop and FSEventStreamUnscheduleFromRunLoop DllImport externs to resolve xtro deprecated-attribute-missing entries. - Fix bug in UnscheduleFromRunLoop that incorrectly called FSEventStreamScheduleWithRunLoop instead of FSEventStreamUnscheduleFromRunLoop. - Remove resolved macOS-CoreServices.todo file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enable MediaSetup framework bindings for Mac Catalyst (16.0): - Add [MacCatalyst (16, 0)] to MSServiceAccount, MSAuthenticationPresentationContext, and MSSetupSession - Add MediaSetup to MACCATALYST_FRAMEWORKS in frameworks.sources - Register MediaSetup with version 16.0 for Mac Catalyst in Frameworks.cs (remove from unavailable list) - Add MacCatalyst-MediaSetup.ignore for version fields - Remove resolved MacCatalyst-MediaSetup.todo Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Alex Soto <alex@soto.dev>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
## Summary Enable nullable reference types, treat-warnings-as-errors, and use the latest C# language version globally across the entire repository via `Directory.Build.props`. ## Changes ### Global settings (`Directory.Build.props`) * Set `<Nullable>enable</Nullable>` globally. * Set `<TreatWarningsAsErrors>true</TreatWarningsAsErrors>` globally. * Set `<LangVersion>latest</LangVersion>` globally (when not already set). ### Cleanup: remove per-project redundant settings * Remove per-project `<Nullable>enable</Nullable>` from ~100+ `.csproj` files, since it's now set globally. * Remove per-project `<TreatWarningsAsErrors>` and `<WarningsAsErrors>` settings that are now redundant. * Remove per-project `<LangVersion>` settings that are now covered by the global default. ### Fix nullability warnings in test code * **bindings-test**: Fix nullability issues in `ProtocolTest.cs`, `Registrar.cs`, `RuntimeTest.cs`. * **dont-link**: Fix nullability issues across multiple test files. * **link all**: Fix nullability issues in link-all tests. * **link sdk**: Fix nullability issues in link-sdk tests. * **BundledResources**: Fix nullability in `ResourcesTest.cs`. * **F# tests**: Fix nullability issues in F# test code. * **Other**: Minor nullability fix in `generate-frameworks-constants.cs`. 🤖 Pull request created by Copilot With this change, nullability is fully enabled everywhere, so: * Fixes #17285. * Fixes #6154. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…1: Build ID 14038264 (#25361) This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.
Don't override the GetTargetPath/Build/Rebuild targets for app extensions, because we also override some of these targets when building remotely, and the custom logic for app extensions is overridden. Instead create new targets that depend on those we previously overrode instead. Fixes #23516. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2542958.
I asked Copilot to review our agentic workflows according to https://github.com/dotnet/vitals/blob/main/.agents/skills/gh-aw-guide/SKILL.md, and this is what it came up with: * Fix 'maintainer' → 'maintain' (correct GitHub role name) * Change min-integrity from 'none' to 'approved' for both workflows (safer default for public repos, prevents XPIA from untrusted content) * Add concurrency groups (cancel-in-progress: false for slash_command, true for schedule/dispatch) * Add supersede-older-reviews: true on reviewer (auto-dismiss stale REQUEST_CHANGES reviews) * Use fuzzy schedule 'daily' instead of fixed cron for code-radiator * Add target: "*" on add-comment/add-labels for code-radiator (no triggering PR context on schedule/dispatch) * Recompile lock files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This pull request updates the following dependencies ## From https://github.com/dotnet/xharness - **Subscription**: [02e03784-16b3-4ced-b02a-3715797fc7da](https://maestro.dot.net/subscriptions?search=02e03784-16b3-4ced-b02a-3715797fc7da) - **Build**: [20260514.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2974748) ([314304](https://maestro.dot.net/channel/2/github:dotnet:xharness/build/314304)) - **Date Produced**: May 14, 2026 9:16:56 AM UTC - **Commit**: [51ca379106cfd749a498cb0822210ef1aa926e41](dotnet/xharness@51ca379) - **Branch**: [main](https://github.com/dotnet/xharness/tree/main) - **Dependency Updates**: - From [11.0.0-prerelease.26230.4 to 11.0.0-prerelease.26264.1][1] - Microsoft.DotNet.XHarness.iOS.Shared [1]: dotnet/xharness@92962e5...51ca379
Convert classic NUnit assertions (`Assert.AreEqual`, `Assert.IsTrue`, `Assert.IsNotNull`, etc.) to NUnit v4's constraint-based `Assert.That` syntax in the msbuild test projects. Also update package references to use centralized version properties from `Directory.Build.props`: - `NUnit` → `$(NUnitPackageVersion)` - `NUnit3TestAdapter` → `$(NUnit3TestAdapterPackageVersion)` - `Microsoft.NET.Test.Sdk` → `$(MicrosoftNETTestSdkPackageVersion)` Two shared files (`tests/common/DotNet.cs`, `tests/common/mac/ProjectTestHelpers.cs`) are also converted — the `Assert.That` constraint syntax is compatible with both NUnit 3 and 4, so other projects referencing these files are unaffected. All `tests-msbuild` tests pass (495 passed, 0 failed). 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use GroupBy before ToDictionary to handle potential duplicate class names in the typeMap file gracefully, rather than throwing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add $(_ILTrimSurvivingClassesFile) and $(_NativeAOTSurvivingClassesFile) to target Outputs and FileWrites for correct incremental builds. - Validate TypeMapFilePath existence before reading, with a clear error. - Error on duplicate class keys in the type map dictionary. - Add '|release' to the NativeAOT .NET 11 defaults test variation. - Fix typo: 'should referenced' → 'should be referenced'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This will eventually become 27.0, when .NET 11 goes stable (for now there's no Xcode 26.0 support in .NET 11, only Xcode 26.5).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…26-05-18' into dev/rolf/inline-class-gethandle-net11.0
rolfbjarne
force-pushed
the
dev/rolf/inline-class-gethandle-net11.0
branch
from
9bce624 to
4682803
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
🔥 [CI Build #4682803] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 148 tests failed, 49 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ framework tests2 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ fsharp tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ interdependent-binding-projects tests4 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ introspection tests3 tests failed, 6 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests32 tests failed, 12 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)21 tests failed, 3 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)24 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)14 tests failed, 7 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)24 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests1 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ xcframework tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Sonoma (14) tests5 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Sequoia (15) tests5 tests failed, 0 tests passed.Failed tests
|
Collaborator
✅ [PR Build #ee96bac] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
Collaborator
✅ [PR Build #ee96bac] Build passed (Build packages) ✅Pipeline on Agent |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
✅ [PR Build #ee96bac] Build passed (Build macOS tests) ✅Pipeline on Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT REVIEW
This PR is only to get CI results.