Migrate to dita-bootstrap GitHub org#306
Conversation
- Rename plug-in ID `net.infotexture.dita-bootstrap` → `org.dita-bootstrap.html` in plugin.xml,
Ant build templates, XSL `plugin:` URI imports, CI workflow, README, and sample DITA files.
- Update GitHub URLs from `infotexture/dita-bootstrap` → `dita-bootstrap/dita-bootstrap` and the
GitHub Pages site `infotexture.github.io/dita-bootstrap` → `dita-bootstrap.github.io`.
- Cross-references to `dita-bootstrap.{lunr,sass,extension,table}` updated to the new `org.dita-bootstrap.*`
plug-in IDs and to the new GitHub org URLs.
Signed-off-by: Roger Sheen <roger@infotexture.net>
jason-fox
left a comment
There was a problem hiding this comment.
Some of the links are lacking .html - I think this should fix them.
I would also add a badge similar to the dita-bootstrap.specialization one:
Note that neither the dita-bootstrap.html nor dita-bootstrap.specialization websites are the primary URL anymore - that is generated from the dita-bootstrap.github.io repo, which is currently using the specialization DITA with the tabbed dialog.
It would be possible to add the tabbed dialog here too, but I'd prefer to do that after completing this migration merge.
| https://github.com/jason-fox/fox.jason.extend.css/archive/master.zip | ||
| dita --install \ | ||
| https://github.com/infotexture/dita-bootstrap/archive/master.zip | ||
| https://github.com/dita-bootstrap/dita-bootstrap/archive/master.zip |
There was a problem hiding this comment.
| https://github.com/dita-bootstrap/dita-bootstrap/archive/master.zip | |
| https://github.com/dita-bootstrap/dita-bootstrap.html/archive/master.zip |
There was a problem hiding this comment.
Wasn't sure we wanted to rename the repo too, or just the plug-in ID, but I suppose using the same for both is least confusing.
| <a | ||
| class="btn m-1" | ||
| href="https://github.com/infotexture/dita-bootstrap" | ||
| href="https://github.com/dita-bootstrap/dita-bootstrap" |
There was a problem hiding this comment.
| href="https://github.com/dita-bootstrap/dita-bootstrap" | |
| href="https://github.com/dita-bootstrap/dita-bootstrap.html" |
| </button> | ||
| </div> | ||
| <a class="navbar-brand" href="https://infotexture.github.io/dita-bootstrap"> | ||
| <a class="navbar-brand" href="https://dita-bootstrap.github.io"> |
There was a problem hiding this comment.
| <a class="navbar-brand" href="https://dita-bootstrap.github.io"> | |
| <a class="navbar-brand" href="https://dita-bootstrap.github.io/dita-bootstrap.html"> |
There was a problem hiding this comment.
I don't think this change is correct, since so far the main plug-in has been represented by the project's landing page, rather than a subpage.
There was a problem hiding this comment.
the main plug-in has been represented by the project's landing page, rather than a subpage.
The overall organization website is the new landing page, and dita-bootstrap.github.io is no longer built using the HTML plugin's header.xml - it is a separate CI in a separate repo. dita-bootstrap.github.io/dita-bootstrap.html/index.html is just the CI build for testing:
- https://dita-bootstrap.github.io/dita-bootstrap.html is just a test page for generating the
output-classbased DITA. with menu links only to dita-bootstrap.html - https://dita-bootstrap.github.io/dita-bootstrap.specialization is just a test page for generating the DTD specialized based DITA. with menu links only to . dita-bootstrap.specialization
This means that the sample files are examples either using or not using the DTD
This is why I suggest adding a badge to the header here, since https://dita-bootstrap.github.io/dita-bootstrap.html is just a subpage test website. I'd also consider altering the header background from primary to bg-light to make it even more obvious that this isn't the main website
The main landing page could easily be built from either of these sources - currently building from the specialization. The main landing-page now has dropdown menus to link to all the plugins, not just the HTML
| >--install</parmname> https://github.com/jason-fox/fox.jason.extend.css/archive/master.zip | ||
| <cmdname>dita</cmdname> <parmname | ||
| >--install</parmname> https://github.com/infotexture/dita-bootstrap/archive/master.zip</codeblock> | ||
| >--install</parmname> https://github.com/dita-bootstrap/dita-bootstrap/archive/master.zip</codeblock> |
There was a problem hiding this comment.
| >--install</parmname> https://github.com/dita-bootstrap/dita-bootstrap/archive/master.zip</codeblock> | |
| >--install</parmname> https://github.com/dita-bootstrap/dita-bootstrap.html/archive/master.zip</codeblock> |
| <p>The plug-in includes a sample color mode toggler in its | ||
| <xref | ||
| href="https://github.com/infotexture/dita-bootstrap/blob/develop/includes/hdr.navbar.example.xml" | ||
| href="https://github.com/dita-bootstrap/dita-bootstrap/blob/develop/includes/hdr.navbar.example.xml" |
There was a problem hiding this comment.
| href="https://github.com/dita-bootstrap/dita-bootstrap/blob/develop/includes/hdr.navbar.example.xml" | |
| href="https://github.com/dita-bootstrap/dita-bootstrap.html/blob/develop/includes/hdr.navbar.example.xml" |
| fox.jason.extend.css | ||
| https://github.com/infotexture/dita-bootstrap/archive/develop.zip | ||
| net.infotexture.dita-bootstrap.lunr | ||
| https://github.com/dita-bootstrap/dita-bootstrap/archive/develop.zip |
There was a problem hiding this comment.
| https://github.com/dita-bootstrap/dita-bootstrap/archive/develop.zip | |
| https://github.com/dita-bootstrap/dita-bootstrap.html/archive/develop.zip |
| <a | ||
| class="nav-link" | ||
| href="https://github.com/infotexture/dita-bootstrap" | ||
| href="https://github.com/dita-bootstrap/dita-bootstrap" |
There was a problem hiding this comment.
| href="https://github.com/dita-bootstrap/dita-bootstrap" | |
| href="https://github.com/dita-bootstrap/dita-bootstrap.html" |
| <a | ||
| class="nav-link" | ||
| href="https://github.com/infotexture/dita-bootstrap/releases" | ||
| href="https://github.com/dita-bootstrap/dita-bootstrap/releases" |
There was a problem hiding this comment.
| href="https://github.com/dita-bootstrap/dita-bootstrap/releases" | |
| href="https://github.com/dita-bootstrap/dita-bootstrap.html/releases" |
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/infotexture/dita-bootstrap.git" | ||
| "url": "https://github.com/dita-bootstrap/dita-bootstrap.git" |
There was a problem hiding this comment.
| "url": "https://github.com/dita-bootstrap/dita-bootstrap.git" | |
| "url": "https://github.com/dita-bootstrap/dita-bootstrap.html.git" |
|
Another thing we'll need to do as part of the merge, update the README of |
That should've been part of the open PRs for those plug-ins, but if something's missing there we can push another commit to include those changes along with the others. |
Not sure the white-on-teal would pass minimum contrast ratios for accessibility, but that shouldn't be hard to adjust. The standard gray “secondary” variant might be more suitable there. |
Not really an issue - CI subdomain builds are only for testing - I just want these testing sub-pages to indicating its as probably not where a user want to be.
Why not follow the same scheme as specialization? <nav class="navbar navbar-expand-lg navbar navbar-expand-lg bg-secondary-subtle">
...
DITA Bootstrap
<span class="badge bg-dark small m-0">outputClass</span>
... etc. |
| name="open-graph.url" | ||
| value="https://infotexture.github.io/dita-bootstrap" | ||
| /> | ||
| <param name="open-graph.url" value="https://dita-bootstrap.github.io"/> |
There was a problem hiding this comment.
With the recent update to the open-graph plugin, this will also set the canonical meta data to https://dita-bootstrap.github.io, which is good, it will mean search engines should start to index that URL rather than the https://dita-bootstrap.github.io/dita-bootstrap.html/ clone or the old https://infotexture.github.io/dita-bootstrap/
net.infotexture.dita-bootstrap→org.dita-bootstrap.htmlin plugin.xml, Ant build templates, XSLplugin:URI imports, CI workflow, README, and sample DITA files.infotexture/dita-bootstrap→dita-bootstrap/dita-bootstrapand the GitHub Pages siteinfotexture.github.io/dita-bootstrap→dita-bootstrap.github.io.dita-bootstrap.{lunr,sass,extension,table}updated to the neworg.dita-bootstrap.*plug-in IDs and to the new GitHub org URLs.