Skip to content

Jeff/fix/rosnav8#1791

Open
jeff-hykin wants to merge 472 commits intomainfrom
jeff/fix/rosnav8
Open

Jeff/fix/rosnav8#1791
jeff-hykin wants to merge 472 commits intomainfrom
jeff/fix/rosnav8

Conversation

@jeff-hykin
Copy link
Copy Markdown
Member

@jeff-hykin jeff-hykin commented Apr 16, 2026

Pre-requisite PRs

POST-MERGE Requirements

Problem

We need nav

Solution

  • port over the whole nav stack all at once

Breaking Changes

  • None

How to Test

git checkout jeff/fix/rosnav8

# needs testing, but is in a testable state
git checkout cfdeee339f4acb7a3dbe12d803743ee4ec70bc05

# simulation
uv run dimos run unitree-g1-nav-sim

# real
uv run dimos --rerun-host 0.0.0.0 run unitree-g1-nav-onboard

Contributor License Agreement

  • I have read and approved the CLA.

@jeff-hykin jeff-hykin marked this pull request as draft April 16, 2026 05:16
@jeff-hykin jeff-hykin marked this pull request as ready for review April 16, 2026 05:56
Comment thread dimos/hardware/sensors/lidar/livox/cpp/flake.nix
@leshy
Copy link
Copy Markdown
Contributor

leshy commented Apr 16, 2026

maybe I'd think of a better name then "smartnav" - so many things are so smart today this prefix doesn't add information for me, "rosnav" has been our internal name which is still better imo, does this nav stack have some offical name?

Comment thread dimos/hardware/sensors/lidar/fastlio2/cpp/main.cpp
Comment thread dimos/navigation/smart_nav/modules/global_map_updater/global_map_updater.py Outdated
Comment thread dimos/navigation/smart_nav/modules/global_map_updater/global_map_updater.py Outdated
Comment thread dimos/navigation/smart_nav/modules/global_map_updater/global_map_updater.py Outdated
@jeff-hykin
Copy link
Copy Markdown
Member Author

"rosnav" has been our internal name which is still better imo, does this nav stack have some offical name?

I'm also not a fan of smart_nav, but:

  • at one point there was rosnav (docker) and non_ros_nav in the same branch
  • nav2 is already a library so I couldn't call it that
  • so smart_nav was named back then
  • Afik (who has been working on this since rosnav3 with docker) yesterday was like "why are you calling it rosnav7 when you took the ros out of it"

I asked claude just now and it suggested NavCore which I think is at least better than rosnav and smart_nav

Comment thread dimos/navigation/nav_stack/modules/simple_planner/simple_planner.py
Comment thread dimos/navigation/nav_stack/tests/test_cross_wall_planning_far.py
Comment thread dimos/msgs/geometry_msgs/Point32.py Outdated
Comment thread dimos/msgs/std_msgs/Float32.py Outdated
Comment thread dimos/hardware/sensors/lidar/fastlio2/cpp/flake.nix
Comment thread dimos/hardware/sensors/lidar/common/livox_sdk_config.hpp Outdated
Comment thread dimos/hardware/sensors/lidar/fastlio2/config/default.yaml
Comment thread dimos/hardware/sensors/lidar/fastlio2/cpp/CMakeLists.txt
@leshy
Copy link
Copy Markdown
Contributor

leshy commented Apr 17, 2026

I asked claude just now and it suggested NavCore which I think is at least better than rosnav and smart_nav

CMUNav? ProfYangNav? this nav stack does have an actual name afaik, don't name it NavCore as this is just one of the nav systems and def not core since will be replaced, needs a unique name for a project, we will invent a name if it doesn't have one

Comment thread dimos/hardware/sensors/lidar/fastlio2/module.py Outdated
Comment thread dimos/hardware/sensors/lidar/fastlio2/module.py
Comment thread dimos/msgs/geometry_msgs/Polygon.py Outdated
Comment thread dimos/msgs/geometry_msgs/PoseWithCovariance.py Outdated
Comment thread dimos/msgs/nav_msgs/ContourPolygons3D.py
Comment thread dimos/hardware/sensors/lidar/fastlio2/cpp/cloud_filter.hpp Outdated
Comment thread dimos/navigation/replanning_a_star/module.py
Comment thread dimos/hardware/sensors/lidar/fastlio2/cpp/flake.nix Outdated
Comment thread dimos/hardware/sensors/lidar/fastlio2/cpp/flake.nix
Comment thread dimos/navigation/nav_stack/modules/far_planner/far_planner.py
Comment thread dimos/hardware/sensors/lidar/fastlio2/module.py
Comment thread dimos/msgs/sensor_msgs/PointCloud2.py
Comment thread dimos/navigation/nav_stack/modules/pgo/cpp/main.cpp
@jeff-hykin jeff-hykin changed the base branch from legacy-dev-dont-merge to main May 9, 2026 08:54
@jeff-hykin jeff-hykin force-pushed the jeff/fix/rosnav8 branch 2 times, most recently from 23168e4 to cfdeee3 Compare May 9, 2026 09:44
@jeff-hykin jeff-hykin enabled auto-merge (squash) May 9, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants