Skip to content

feat: adding tmux to UDI 9 / 10#254

Open
ibuziuk wants to merge 1 commit intomainfrom
tmux
Open

feat: adding tmux to UDI 9 / 10#254
ibuziuk wants to merge 1 commit intomainfrom
tmux

Conversation

@ibuziuk
Copy link
Copy Markdown
Contributor

@ibuziuk ibuziuk commented Apr 24, 2026

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8262ea58-bf27-4bbe-a5b6-9effa0a408ca

📥 Commits

Reviewing files that changed from the base of the PR and between 4c51c6a and c7d21f3.

📒 Files selected for processing (2)
  • universal/ubi10/Dockerfile
  • universal/ubi9/Dockerfile

📝 Walkthrough

Walkthrough

Both UBI 9 and UBI 10 Dockerfile container images are updated to include tmux in their package installation step alongside bash-completion. The cleanup procedures remain unchanged.

Changes

Cohort / File(s) Summary
Container Base Images
universal/ubi9/Dockerfile, universal/ubi10/Dockerfile
Added tmux package to the dnf package installation command for both UBI 9 and UBI 10 base images.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hoppy hops through container land,
Where shells and tools now closer stand,
Tmux joins the bash-completion crew,
UBI images fresh and new!
A tiny change, but oh, so grand! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding tmux to UDI 9 and UDI 10 Dockerfiles, which matches the modifications shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tmux

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ibuziuk ibuziuk requested review from rohanKanojia and tolusha April 24, 2026 11:01
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, rohanKanojia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk
Copy link
Copy Markdown
Contributor Author

ibuziuk commented Apr 24, 2026

hmm.. looks like installation is failing - https://github.com/tmux/tmux/wiki/Installing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants