Extend status command output#1868
Conversation
rolandwalker
force-pushed
the
RW/extend-and-align-status-output
branch
from
a925d02 to
1c9c280
Compare
| output.append(("Db characterset:", charset[1])) | ||
| output.append(("Client characterset:", charset[2])) | ||
| output.append(("Conn. characterset:", charset[3])) | ||
| charset_spec = [ |
There was a problem hiding this comment.
Should we let the cli_helpers render format these instead of forcing a format?
There was a problem hiding this comment.
I don't quite understand. It does get formatted into a table by cli_helpers.
There was a problem hiding this comment.
I mean the spacing like Db characterset:, adding the spaces in between. But if that is the only way to get the alignment you want then that works.
| output.append(("Server version:", f'{variables["version"]} {variables["version_comment"]}')) | ||
| output.append(("Protocol version:", variables["protocol_version"])) | ||
| output.append(('SSL/TLS version:', get_ssl_version(cur))) | ||
| output.append(("Using delimiter:", iocommands.delimiter_command.current)) |
There was a problem hiding this comment.
Could this use get_current_delimiter() from iocommands instead?
There was a problem hiding this comment.
Original suggestion was to use iocommands.get_current_delimiter() possibly instead of iocommands.delimiter_command.current since that function exists to get the value instead of directly accessing the property
There was a problem hiding this comment.
Yes! I made the change.
There was a problem hiding this comment.
@rolandwalker Hah sorry, was looking at my own comment thinking it would be updated for some reason. Still too early I guess :p
|
|
||
| Features | ||
| --------- | ||
| * Add more output to the `status` commnad. |
* recast "variables" as "global_variables" * add "session_variables" dict * tighten legacy-server decoding logic * derive charset rows from "session_variables" instead of a new query * add "Using delimiter" row, matching the vendor client * add "Using outfile" row (tee target), matching the vendor client * add SSL cipher row, matching the vendor client * add "Result characterset" row, an extension beyond the vendor client * add "Server timezone" row, an extension * add "Local timezone" row, an extension * align charset key names * make more None/null values the empty string, for consistency and to match the vendor client * add header so that "status\G" doesn't crash within cli_helpers * tweak some commentary The vendor client also shows the setting for how binary data is rendered, which seems more difficult for mycli to include.
rolandwalker
force-pushed
the
RW/extend-and-align-status-output
branch
from
1c9c280 to
0d23663
Compare
2 participants
Description
variablesasglobal_variablessession_variablesdictsession_variablesinstead of a new querystatus\Gdoesn't crash withincli_helpersThe vendor client also shows the setting for how binary data is rendered, which seems more difficult for mycli to include.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).