Skip to content

Bump google-java-format to 1.27.0 and fmt CI JDK to 17 #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Divyansh-db wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −6
Open

Bump google-java-format to 1.27.0 and fmt CI JDK to 17 #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ jobs:
- name: Setup build environment
uses: ./.github/actions/setup-build-environment
with:
java-version: 11
# google-java-format 1.27.0 (pinned in pom.xml) requires JRE 17+ to run.
java-version: 17

- name: Check formatting
run: mvn --errors spotless:check
Expand Down
10 changes: 5 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@
<java>
<!-- <cleanthat/> This can be added after we drop java 8 support -->
<googleJavaFormat>
<!-- 1.22.0 is the last GJF release that supports JRE 11 (1.23+ requires JRE 17).
Needed to support newer JDKs (e.g. the code-generator's JDK 25) where the
spotless-bundled default (1.15.0) fails with NoSuchMethodError against
javac internals (Log$DeferredDiagnosticHandler.getDiagnostics). -->
<version>1.22.0</version>
<!-- 1.27.0 is the first GJF release with the fix for the JDK 23+
Log$DeferredDiagnosticHandler signature change (required for the
code-generator's JDK 25 environment). Requires JRE 17+ to run, which
is why the fmt CI job (.github/workflows/push.yml) pins JDK 17. -->
<version>1.27.0</version>
</googleJavaFormat>
<importOrder/>
<removeUnusedImports/>
Expand Down
Loading