Remove experimentalIsUnifiedHost flag from DatabricksConfig#773
Merged
hectorcast-db merged 2 commits intomainfrom Apr 22, 2026
Merged
Remove experimentalIsUnifiedHost flag from DatabricksConfig#773hectorcast-db merged 2 commits intomainfrom
hectorcast-db merged 2 commits intomainfrom
Conversation
2 tasks
Drops the experimentalIsUnifiedHost field and the DATABRICKS_EXPERIMENTAL_IS_UNIFIED_HOST env var. The flag was never read — getHostType() derives the host type from the URL pattern, and unified-host metadata fields (accountId, workspaceId, discoveryUrl) are auto-resolved via /.well-known/databricks-config during config.resolve(). No production path referenced the flag, and no tests set it. Ports databricks/databricks-sdk-go#1641 and databricks/databricks-sdk-py#1358. This is a compile-time breaking change. Downstream callers that were setting the flag should drop those calls. Co-authored-by: Isaac
db1c61c to
3e81d21
Compare
Completes the port of databricks/databricks-sdk-go#1641 and databricks/databricks-sdk-py#1358 by aligning README with what Go and Python published. Changes: - Add "Unified host support" entry + "GCP native authentication" entry to the auth "In this section" TOC. - List GCP as the third step of the default auth order, and explain that auth methods auto-skip when their required config is absent. Show how to force a method via DatabricksConfig.setAuthType. - Add a "Unified host support" section with a .databrickscfg example and equivalent Java code (WorkspaceClient + AccountClient sharing one profile, plus overriding workspace_id). - Extend the native-auth attribute table with workspace_id and discovery_url, mark account_id / workspace_id / discovery_url as auto-discoverable, and note that auto-discovery never overwrites explicit values. The Go/Python PRs also document a "cloud" config field; Java does not (yet) expose one on DatabricksConfig, so it is omitted here. Co-authored-by: Isaac
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
tanmay-db
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports databricks/databricks-sdk-go#1641 and databricks/databricks-sdk-py#1358 to the Java SDK.
Drops the
experimentalIsUnifiedHostfield and theDATABRICKS_EXPERIMENTAL_IS_UNIFIED_HOSTenvironment variable fromDatabricksConfig. The flag was never read in production:DatabricksConfig.getHostType()derives the host type purely from the URL pattern.accountId,workspaceId,discoveryUrl) are auto-resolved via/.well-known/databricks-configduringconfig.resolve().No production path referenced the flag, and no tests set it (confirmed via grep across the repo).
Breaking change
This is a compile-time breaking change. Downstream callers that were setting the flag should drop those calls:
No user-facing replacement is needed — unified host detection is automatic.
Scope vs. the Go/Python PRs
Experimental_IsUnifiedHostfield + env varErrWorkspaceIDInAccountClient(Go only)Test plan
mvn compilecleanmvn test— 1187 tests pass, no regressionsexperimentalIsUnifiedHost/EXPERIMENTAL_IS_UNIFIED_HOSTin the repo (grep clean)This pull request was AI-assisted by Isaac.