Skip to content

cmd/bundle: remove summary --show-full-config#5241

Merged
pavloKozlov merged 1 commit into
mainfrom
remove-summary-show-full-config
May 12, 2026
Merged

cmd/bundle: remove summary --show-full-config#5241
pavloKozlov merged 1 commit into
mainfrom
remove-summary-show-full-config

Conversation

@pavloKozlov
Copy link
Copy Markdown
Contributor

@pavloKozlov pavloKozlov commented May 12, 2026

Summary

  • Removes the hidden bundle summary --show-full-config flag and its handler from cmd/bundle/summary.go.
  • Deletes the corresponding acceptance/bundle/summary/show-full-config/ test directory.
  • The flag has been superseded by bundle debug list-targets, which already covers the same use case.

Test plan

  • ./task build succeeds.
  • ./task test passes; no acceptance tests reference --show-full-config.
  • databricks bundle summary --show-full-config now errors with "unknown flag" as expected.
  • databricks bundle debug list-targets continues to work as the replacement.

@pavloKozlov
cmd/bundle: remove summary --show-full-config
062f3a0 
The hidden `--show-full-config` flag has been superseded by
`bundle debug list-targets`. Drop the flag, its handler, and the
corresponding acceptance test directory.
@pavloKozlov pavloKozlov temporarily deployed to test-trigger-is May 12, 2026 12:26 — with GitHub Actions Inactive
@pavloKozlov pavloKozlov temporarily deployed to test-trigger-is May 12, 2026 12:26 — with GitHub Actions Inactive
ilyakuz-db
ilyakuz-db approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ilyakuz-db ilyakuz-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like "show-full-config" acceptance tests cover more than "list-targets". Should we add more tests to the list-targets acceptance suite?

@pavloKozlov pavloKozlov merged commit 4bba7bd into main May 12, 2026
26 of 27 checks passed
@pavloKozlov pavloKozlov deleted the remove-summary-show-full-config branch May 12, 2026 14:28
@pavloKozlov
Copy link
Copy Markdown
Contributor Author

pavloKozlov commented May 12, 2026

Looks like "show-full-config" acceptance tests cover more than "list-targets". Should we add more tests to the list-targets acceptance suite?

Acceptance tests for show-full-config was covering --include-locations and dashboard resources. New list-targets command doesn't have resolve locations and dashboards - they're retrieved via summary command.
Let me know you think there is a specific case that is missed.

@ilyakuz-db
Copy link
Copy Markdown
Contributor

ilyakuz-db commented May 12, 2026

Looks like "show-full-config" acceptance tests cover more than "list-targets". Should we add more tests to the list-targets acceptance suite?

Acceptance tests for show-full-config was covering --include-locations and dashboard resources. New list-targets command doesn't have resolve locations and dashboards - they're retrieved via summary command. Let me know you think there is a specific case that is missed.

Makes sense, thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denik denik denik approved these changes

@ilyakuz-db ilyakuz-db ilyakuz-db approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pavloKozlov @ilyakuz-db @denik