acc: unset AI-agent env vars instead of setting them empty#5240
Merged
Conversation
Move the agent env var scrub from acceptance/test.toml into acceptance_test.go and use os.Unsetenv so the keys are truly absent in child processes. The old `Env.X = ""` approach left them present with an empty value; since SDK v0.132 the user-agent detector treats that as a match and stamps `agent/multiple` onto recorded requests. Co-authored-by: Isaac
denik
approved these changes
May 12, 2026
simonfaltum
approved these changes
May 12, 2026
simonfaltum
added a commit
that referenced
this pull request
May 12, 2026
Picks up #5240, which unsets AI-agent env vars in acceptance tests so the SDK v0.132 user-agent detector stops stamping 'agent/multiple' on recorded requests.
simonfaltum
added a commit
that referenced
this pull request
May 12, 2026
#5240 unsets the AI-agent env vars in acceptance instead of setting them empty. The SDK v0.132 detector treats empty values as a match, so recorded requests were stamped with agent/multiple after the SDK bump. With #5240 merged in, the detector no longer fires; strip the suffix from all affected goldens. Verified by re-running the affected tests.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the agent env var scrub from
acceptance/test.tomlintoacceptance_test.goand useos.Unsetenvso the keys are truly absent in child processes.The old
Env.X = ""approach left them present with an empty value; since SDK v0.132 the user-agent detector treats that as a match and stampsagent/multipleonto recorded requests.This pull request and its description were written by Isaac.