-
Notifications
You must be signed in to change notification settings - Fork 167
Resolve AppKit and Agent Skills versions from compatibility manifest #5139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
55c23c7
feat: move cli-compat manifest to CLI repo with 3-tier fallback
pkosiec 0ae73a2
fix: address code review findings
pkosiec 77186ec
Rename depversions to clicompat and improve code quality
pkosiec 41ecb8a
Update cli-compat manifest to CLI 0.300.0 and skills 0.1.5
pkosiec 4e8a205
fix: address code review findings
pkosiec 0262d64
Fall back to embedded manifest when resolved version is not found
pkosiec 1744468
fix: address code review findings for clicompat
pkosiec 847438f
fix: improve fallback guards for AppKit and skills resolution
pkosiec 1491783
fix: skip skills fallback when DATABRICKS_SKILLS_REF is explicitly set
pkosiec ea39588
refactor: remove "next" key from compat manifest, add DATABRICKS_FORC…
pkosiec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,153 @@ | ||
| --- | ||
| name: bump-cli-compat | ||
| description: "Bump cli-compat.json with new AppKit and Agent Skills versions, then create a PR. Use when the user says 'bump cli-compat', 'update cli-compat', 'bump compatibility manifest', 'new appkit release cli-compat', or wants to update the CLI compatibility manifest after an AppKit or Agent Skills release." | ||
| user-invocable: true | ||
| allowed-tools: Read, Edit, Write, Bash, Glob, Grep, AskUserQuestion | ||
| --- | ||
|
|
||
| # Bump CLI Compatibility Manifest | ||
|
|
||
| Updates `internal/build/cli-compat.json` with new AppKit and Agent Skills versions, validates the result, and creates a PR. | ||
|
|
||
| ## Arguments | ||
|
|
||
| Parse the user's input for optional named flags: | ||
|
|
||
| - `--appkit <version>` → AppKit version (e.g. `0.28.0`) | ||
| - `--skills <version>` → Agent Skills version (e.g. `0.1.6`) | ||
| - No args → auto-detect latest versions from GitHub tags | ||
|
|
||
| Versions should be provided **without** the `v` prefix (e.g. `0.28.0`, not `v0.28.0`). If provided with the prefix, strip it. | ||
|
|
||
| ## Workflow | ||
|
|
||
| ### Step 1: Resolve versions | ||
|
|
||
| If both `--appkit` and `--skills` versions were provided, skip to Step 2. | ||
|
|
||
| For any missing version, fetch the latest tag from GitHub: | ||
|
|
||
| ```bash | ||
| # Latest appkit version (strip leading 'v') | ||
| gh api repos/databricks/appkit/tags --jq '.[0].name' | sed 's/^v//' | ||
|
|
||
| # Latest skills version (strip leading 'v') | ||
| gh api repos/databricks/databricks-agent-skills/tags --jq '.[0].name' | sed 's/^v//' | ||
| ``` | ||
|
|
||
| Show the resolved versions to the user and ask: | ||
|
|
||
| > The latest versions are: | ||
| > - AppKit: `{appkit_version}` | ||
| > - Agent Skills: `{skills_version}` | ||
| > | ||
| > Have these versions been evaluated (evals passed with no regressions)? | ||
|
|
||
| **Do NOT proceed until the user confirms.** If the user says no or wants different versions, ask them to provide the correct versions. | ||
|
|
||
| ### Step 2: Validate tags exist | ||
|
|
||
| Verify that the corresponding Git tags exist on GitHub. For AppKit, also validate the `template-v` tag (used by `apps init`): | ||
|
|
||
| ```bash | ||
| # AppKit release tag | ||
| gh api repos/databricks/appkit/git/ref/tags/v{appkit_version} --jq '.ref' | ||
|
|
||
| # AppKit template tag (used by apps init) | ||
| gh api repos/databricks/appkit/git/ref/tags/template-v{appkit_version} --jq '.ref' | ||
|
|
||
| # Agent Skills tag | ||
| gh api repos/databricks/databricks-agent-skills/git/ref/tags/v{skills_version} --jq '.ref' | ||
| ``` | ||
|
|
||
| If any tag doesn't exist, report the error and stop. | ||
|
|
||
| ### Step 3: Read current manifest | ||
|
|
||
| Read `internal/build/cli-compat.json`. Note the current versions and the list of versioned entries. | ||
|
|
||
| ### Step 4: Determine update type | ||
|
|
||
| Ask the user: | ||
|
|
||
| > Do any of these apply? | ||
| > - **AppKit**: The new templates require new CLI logic in `apps init` (e.g. new flags, prompts, or template handling that older CLIs don't have) | ||
| > - **Skills**: The new skills version uses CLI commands that older CLIs don't support | ||
| > | ||
| > If **neither** applies, this is a non-breaking bump (default). | ||
|
|
||
| - **No breaking changes** (default): proceed to Step 4a. | ||
| - **Breaking changes**: proceed to Step 4b. | ||
|
|
||
| ### Step 4a: No breaking changes (update in-place) | ||
|
|
||
| Update the **highest versioned entry** to the new appkit and skills versions. Do NOT add new versioned keys. The manifest is range-based: updating the highest entry automatically covers all CLI versions in that range. | ||
|
|
||
| Write the updated `internal/build/cli-compat.json`. | ||
|
|
||
| ### Step 4b: Breaking changes (add new entry) | ||
|
|
||
| Ask the user for the **minimum CLI version** that supports the new features. | ||
|
|
||
| Add a new entry keyed to that CLI version with the new appkit and skills versions. Keep older entries unchanged so older CLI binaries stay compatible. | ||
|
|
||
| Write the updated `internal/build/cli-compat.json`. | ||
|
|
||
| ### Step 5: Validate | ||
|
|
||
| Run the Go tests to ensure the manifest is well-formed: | ||
|
|
||
| ```bash | ||
| go test ./libs/clicompat/... -run TestEmbeddedManifest -v | ||
| ``` | ||
|
|
||
| If validation fails, show the errors and fix them before proceeding. | ||
|
|
||
| ### Step 6: Create branch, commit, and PR | ||
|
|
||
| ```bash | ||
| # Create a new branch from the current branch (or main) | ||
| git checkout -b bump-cli-compat-appkit-{appkit_version}-skills-{skills_version} | ||
|
|
||
| # Stage and commit | ||
| git add internal/build/cli-compat.json | ||
| git commit -s -m "Bump cli-compat to appkit {appkit_version}, skills {skills_version}" | ||
|
|
||
| # Push and create PR | ||
| git push -u origin HEAD | ||
| gh pr create \ | ||
| --title "Bump cli-compat to appkit {appkit_version}, skills {skills_version}" \ | ||
| --body "$(cat <<'EOF' | ||
| ## Summary | ||
| Bump `cli-compat.json` to use: | ||
| - AppKit `{appkit_version}` | ||
| - Agent Skills `{skills_version}` | ||
|
|
||
| ## Checklist | ||
| - [ ] Evals passed with no regressions | ||
| - [ ] `go test ./libs/clicompat/... -run TestEmbeddedManifest` passes | ||
| EOF | ||
| )" | ||
| ``` | ||
|
|
||
| Show the PR URL to the user when done. | ||
|
|
||
| ## Examples | ||
|
|
||
| ### Example: With explicit versions | ||
| ``` | ||
| /bump-cli-compat --appkit 0.28.0 --skills 0.1.6 | ||
| ``` | ||
| Validates tags exist (including `template-v0.28.0`), updates manifest, creates PR. | ||
|
|
||
| ### Example: Auto-detect latest | ||
| ``` | ||
| /bump-cli-compat | ||
| ``` | ||
| Fetches latest tags, asks for eval confirmation, then updates and creates PR. | ||
|
|
||
| ### Example: Only bump AppKit | ||
| ``` | ||
| /bump-cli-compat --appkit 0.28.0 | ||
| ``` | ||
| Auto-detects latest skills version, asks for confirmation, then updates both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.