Promote aitools skills-management commands to top-level#4917
Promote aitools skills-management commands to top-level#4917jamesbroadhead wants to merge 13 commits into
Conversation
Approval status: pending
|
|
I think we should move the code itself (the files) out of experimental as part of this as well. |
Per Simon's review on #4917, the source files should live outside experimental/ now that aitools is a top-level command. Renames the directory from experimental/aitools/ to aitools/ and updates all import paths, examples, and tooling references (Makefile, OWNERS, testmask, pr-checklist). The experimental/aitools alias still routes to the same package via its new import path, so 'databricks experimental aitools' continues to work as a deprecated entry point. Co-authored-by: Isaac
c1b87a6 to
8b230d7
Compare
…base-tmp # Conflicts: # NEXT_CHANGELOG.md
|
Hi @pietern — Claude here, on James's behalf. Just merged Could you take a look when you have a chance? You've been the most active reviewer/committer in This comment was generated with GitHub MCP. |
|
Hi @jamesbroadhead |
lennartkats-db
left a comment
There was a problem hiding this comment.
Only minor comments, PTAL. And I'd like for @simonfaltum to sign off on this as well since we'd promote aitools out of experimental here (even if he's co-author).
| - Install the AI tools in coding agents (install) | ||
| - Manage skills (skills) | ||
| - Access tools directly (tools)`, | ||
| // Hidden silent backward-compatibility aliases for the skills-management |
There was a problem hiding this comment.
Good to have the backward compatibility, but maybe we can display a warning if they're used? (I think there's a Deprecated property that can be used for this)
…ional # Conflicts: # NEXT_CHANGELOG.md
Per Simon's review: avoid locking the top-level `databricks aitools install` into a positional that means "skill", since the aitools surface may grow commands for things beyond skills. `--skills name1,name2` remains the documented way to scope an install. The legacy alias `experimental aitools skills install <name>` keeps its positional form by translating to `--skills` before delegating. Co-authored-by: Isaac
|
Hi @simonfaltum @lennartkats-db — Claude here, on James's behalf. Update (after this comment was originally posted): Per Simon's request, the interface changes ( #5234 is stacked on this PR (will rebase to The positional The earlier question on whether the PR: #4917 This comment was generated with GitHub MCP. |
b3b6d1a to
9df5e93
Compare
Summary
Move-only PR. Promotes the aitools skills-management surface out of
experimental/to a new top-levelaitools/package, preserving today's behavior. The matching interface changes (--scopeenum,--project/--globaldeprecation,--agentsauto-detect doc) live in a stacked follow-up: #5234.install,update,uninstall,list,version(and the agents/installer libs they depend on) physically move fromexperimental/aitools/to top-levelaitools/, so the directory layout matches the stability tier.databricks aitools ….toolssubtree underexperimental/aitools/—query,discover-schema,get-default-warehouse,statement …— becausetools.gostill says "There are no stability guarantees for these tools".skillsalias group also stays underexperimental/aitools/.databricks experimental aitools install/update/uninstall/list/versionanddatabricks experimental aitools skills install/listkeep working as silent backward-compat aliases — no deprecation warning fires, the commands just forward.The aitools skills-management surface is feature-complete after the 5-PR series (#4810–#4814) that added state tracking, lifecycle commands, and project scope support. The
toolssubtree is functionally useful but its shape is still in flux, so promoting only the stable half.What's not in this PR
These are deliberately separated and reviewed independently:
--scope=project|global|bothflag, deprecation of--project/--globalviacobra.Deprecated,--agentsauto-detect help text.--output jsonondatabricks aitools list.Command shape after this PR
Test plan
databricks aitools --helpshows install/update/uninstall/list/version (notools)databricks --helplistsaitoolsin the outputdatabricks experimental aitools installruns without warning and the work happens (silent alias)databricks experimental aitools tools query …runs as beforedatabricks experimental aitools tools --helplists query/discover-schema/get-default-warehouse/statementexperimental/aitools/cmd/skills_test.goThis pull request was AI-assisted by Isaac.