BUG: torch.meshgrid RuntimeError if no arrays#425
Open
Nin17 wants to merge 3 commits intodata-apis:mainfrom
Open
BUG: torch.meshgrid RuntimeError if no arrays#425Nin17 wants to merge 3 commits intodata-apis:mainfrom
Nin17 wants to merge 3 commits intodata-apis:mainfrom
Conversation
Nin17
changed the title
Author
|
Should I also update the tests to test for this? Or should this be tested at array-api-tests? |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes PyTorch backend meshgrid behavior to match NumPy/Array API expectations when called with no input arrays.
Changes:
- Return an empty tuple from
array_api_compat.torch.meshgrid()when called with no arrays (avoids PyTorchRuntimeError). - Keep explicitly passing
indexing=through totorch.meshgridfor non-empty inputs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Given that the array-api-tests test does not catch this, I think it could be nice to add a quick test here, yes. https://github.com/data-apis/array-api-compat/blob/main/tests/test_torch.py#L117 is the existing |
check indexing first - consistency with numpy+jax.numpy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #424