fix: Increase Strictness of Rollback Check#391
Merged
Conversation
Now that items don't receive a trade cooldown on reversal, their asset ID doesn't change either. This change scopes the check to also ensure that the buyer/seller pair is aligned as well. Ref CSF-1401
GODrums
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that items don't receive a trade cooldown on reversal, their asset ID doesn't change either.
This change scopes the check to also ensure that the buyer/seller pair is aligned as well.
Ref CSF-1401
Note
Medium Risk
Moderate risk because it changes how rollback and cancel pings are correlated to CSFloat trades; overly strict matching could miss legitimate rollbacks, while insufficient data (HTML-parsed history) may reduce detection in fallback paths.
Overview
Improves rollback detection by scoping matches to both the traded
asset_idand the expected buyer/seller counterparty, reducing false positives now that rollbacks may keep the same asset ID.Adds
other_party_idtoTradeHistoryStatus(populated from the Steam API response) and uses it inrollback.tsandtrade_offer.tswhen correlating Steam trade-history rollbacks to pending CSFloat trades.Reviewed by Cursor Bugbot for commit 855a7b2. Bugbot is set up for automated code reviews on this repo. Configure here.