Skip to content

fix: Increase Strictness of Rollback Check#391

Merged
Step7750 merged 2 commits intomasterfrom
fix/strict-rollback-check
May 4, 2026
Merged

fix: Increase Strictness of Rollback Check#391
Step7750 merged 2 commits intomasterfrom
fix/strict-rollback-check

Conversation

@Step7750
Copy link
Copy Markdown
Collaborator

@Step7750 Step7750 commented May 4, 2026

Now that items don't receive a trade cooldown on reversal, their asset ID doesn't change either.

This change scopes the check to also ensure that the buyer/seller pair is aligned as well.

Ref CSF-1401


Note

Medium Risk
Moderate risk because it changes how rollback and cancel pings are correlated to CSFloat trades; overly strict matching could miss legitimate rollbacks, while insufficient data (HTML-parsed history) may reduce detection in fallback paths.

Overview
Improves rollback detection by scoping matches to both the traded asset_id and the expected buyer/seller counterparty, reducing false positives now that rollbacks may keep the same asset ID.

Adds other_party_id to TradeHistoryStatus (populated from the Steam API response) and uses it in rollback.ts and trade_offer.ts when correlating Steam trade-history rollbacks to pending CSFloat trades.

Reviewed by Cursor Bugbot for commit 855a7b2. Bugbot is set up for automated code reviews on this repo. Configure here.

Now that items don't receive a trade cooldown on reversal, their asset ID doesn't change either.

This change scopes the check to also ensure that the buyer/seller pair is aligned as well.

Ref CSF-1401
@Step7750 Step7750 requested a review from GODrums May 4, 2026 22:11
@Step7750 Step7750 added the bug label May 4, 2026
@Step7750 Step7750 merged commit f3de947 into master May 4, 2026
3 checks passed
@Step7750 Step7750 deleted the fix/strict-rollback-check branch May 4, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants