Skip to content

[linalg.algs.blas2.rank1,linalg.algs.blas2.symherrank1] Restore missing arguments in P3371R5 updating overloads #8995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinavagarwal07 wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −5
Open

[linalg.algs.blas2.rank1,linalg.algs.blas2.symherrank1] Restore missing arguments in P3371R5 updating overloads #8995

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d7d099
[linalg.algs.blas2.rank1] Add missing E in matrix_rank_1_update_c eff…
abhinavagarwal07 Apr 26, 2026
8c2557d
[linalg.algs.blas2.symherrank1] Restore parameters in updating overload
abhinavagarwal07 Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions source/numerics.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14994,7 +14994,7 @@
For the overloads without an \tcode{ExecutionPolicy} argument,
equivalent to:
\begin{codeblock}
matrix_rank_1_update(x, conjugated(y), A);
matrix_rank_1_update(x, conjugated(y), E, A);
\end{codeblock}
\item
otherwise, equivalent to:
Expand Down Expand Up @@ -15150,11 +15150,14 @@

\indexlibraryglobal{hermitian_matrix_rank_1_update}%
\begin{itemdecl}
template<@\exposconcept{scalar}@ Scalar, @\exposconcept{possibly-packed-out-matrix}@ OutMat, class Triangle>
void hermitian_matrix_rank_1_update(InVec x, OutMat A, Triangle t);
template<@\exposconcept{scalar}@ Scalar, @\exposconcept{in-vector}@ InVec, @\exposconcept{in-matrix}@ InMat, @\exposconcept{possibly-packed-out-matrix}@ OutMat,
class Triangle>
void hermitian_matrix_rank_1_update(Scalar alpha, InVec x, InMat E, OutMat A, Triangle t);
template<class ExecutionPolicy,
@\exposconcept{scalar}@ Scalar, @\exposconcept{possibly-packed-out-matrix}@ OutMat, class Triangle>
void hermitian_matrix_rank_1_update(ExecutionPolicy&& exec, InVec x, OutMat A, Triangle t);
@\exposconcept{scalar}@ Scalar, @\exposconcept{in-vector}@ InVec, @\exposconcept{in-matrix}@ InMat, @\exposconcept{possibly-packed-out-matrix}@ OutMat,
class Triangle>
void hermitian_matrix_rank_1_update(ExecutionPolicy&& exec,
Scalar alpha, InVec x, InMat E, OutMat A, Triangle t);
\end{itemdecl}

\begin{itemdescr}
Expand Down
Loading