fix(refunder): Align refund submission UIDs with loaded order data#4412
Open
metalurgical wants to merge 2 commits into
Open
fix(refunder): Align refund submission UIDs with loaded order data#4412metalurgical wants to merge 2 commits into
metalurgical wants to merge 2 commits into
Conversation
Keep refund submission UIDs paired with successfully loaded ETHFlow order data. Additionally, skip empty submissions and improve DB error logging.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the refund processing logic in RefundService to ensure that only UIDs with successfully retrieved order data are included in transaction batches. This fixes a previous issue where UIDs and order data could become misaligned. The implementation now uses unzip to maintain alignment and skips submission if no valid orders are found. Tests have been updated to verify these changes. I have no feedback to provide as the existing review comment does not meet the high or critical severity threshold required by the repository style guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep submitted UIDs aligned with successfully loaded ETHFlow order data.
This avoids mismatched internal submission inputs when DB lookups fail, skips empty submissions, and improves failed lookup logging.
Changes
How to test
cargo nextest -p refunder