tsi_dgram: fix sendto_addr binding for AF_INET6 sockets#658
Open
nohajc wants to merge 1 commit intocontainers:mainfrom
Open
tsi_dgram: fix sendto_addr binding for AF_INET6 sockets#658nohajc wants to merge 1 commit intocontainers:mainfrom
nohajc wants to merge 1 commit intocontainers:mainfrom
Conversation
sendto_addr() always bound to SockaddrIn (0.0.0.0:0) regardless of socket family, causing the bind to fail silently for AF_INET6 sockets and leaving them deaf to incoming datagrams. Store the resolved AddressFamily in the proxy and bind to :: when the socket is IPv6. Signed-off-by: Jan Noha <nohajc@gmail.com>
nohajc
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
Collaborator
|
Thanks for the fix! But actually, I just remembered I was going to fix this but I totally forgot about it: 71d5270 I was thinking recently about figuring out how to merge the test - I had trouble setting up a minimal test environment (user namespaces) without running libkrun in podman via crun... But I totally forgot I also fixed the TSI code |
Contributor
Author
|
Sure, we can use your fix. Anyway, it seems my users hit this issue couple times already but it wasn't evident whether it was IPv6 related. I only realized this time... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed DNS was broken in my alpine VM whenever I added an IPv6 nameserver to /etc/resolv.conf. This change fixes the issue.