README.md: Add blurb about what features we expect to expose#99
Open
alexlarsson wants to merge 2 commits intocontainers:mainfrom
Open
README.md: Add blurb about what features we expect to expose#99alexlarsson wants to merge 2 commits intocontainers:mainfrom
alexlarsson wants to merge 2 commits intocontainers:mainfrom
Conversation
Collaborator
Author
|
Does this make sense to people? |
| Features | ||
| -------- | ||
|
|
||
| Bubblewrap tries to expose most useful features that unprivileged user |
Member
There was a problem hiding this comment.
Make this more definitive.
Bubblewrap exposes useful features that unprivileged user
ashcrow
reviewed
Sep 23, 2016
| -------- | ||
|
|
||
| Bubblewrap exposes useful features that are also supported by | ||
| unprivileged user namespaces the Linux kernel. Features that are not |
| Bubblewrap exposes useful features that are also supported by | ||
| unprivileged user namespaces the Linux kernel. Features that are not | ||
| available in an unprivileged mode in the upstream kernel are not | ||
| considered for inclusion, partly to keep non-setuid builds working, |
There was a problem hiding this comment.
nit: I think having a short bullet here would read easier:
- to keep non-setuid builds working
- defer to kernel maintainers on which features are secure to expose to users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.