fix: pass node label value to OverlayBD_Alive metric render#401
Open
SriHarsha001 wants to merge 1 commit into
Open
fix: pass node label value to OverlayBD_Alive metric render#401SriHarsha001 wants to merge 1 commit into
SriHarsha001 wants to merge 1 commit into
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The OverlayBD_Alive metric produces malformed Prometheus exposition format output, causing Prometheus-compatible scrapers (e.g. vmagent) to fail parsing the /metrics endpoint. In src/exporter_handler.h, alive.render(1) is called without providing a string argument for the {node} label placeholder. The template renderer places the metric value and timestamp where the node label value should be, producing:
OverlayBD_Alive{node="1.000000 1778265650342
instead of:
OverlayBD_Alive{node=""} 1.000000 1778265650342
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # This fix stores the machine hostname in ExposeRender and passes it to alive.render(1, node_name.c_str()), producing valid Prometheus output.
Please check the following list: