fix: include <sstream> in audio cell of demo notebook#481
Merged
JohanMabille merged 1 commit intocompiler-research:mainfrom Apr 27, 2026
Merged
fix: include <sstream> in audio cell of demo notebook#481JohanMabille merged 1 commit intocompiler-research:mainfrom
JohanMabille merged 1 commit intocompiler-research:mainfrom
Conversation
The demo notebook's audio cell uses std::stringstream but does not include <sstream>. Some toolchains failed to compile the cell as a result. The wasm demo notebook already includes it. Closes compiler-research#480.
JohanMabille
approved these changes
Apr 27, 2026
Collaborator
JohanMabille
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
- Coverage 74.25% 73.51% -0.74%
==========================================
Files 23 23
Lines 1301 1193 -108
Branches 111 111
==========================================
- Hits 966 877 -89
+ Misses 335 316 -19 see 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #480.
Adds
#include <sstream>to the audio cell oftest/Notebooks/xeus-cpp.ipynb. The cell usesstd::stringstream(au::audio::m_buffer) without the corresponding header, so toolchains that don't transitively include<sstream>via<string>/<fstream>fail to compile the cell, which is what produced the failure in #480.The companion wasm demo notebook (referenced by @anutosh491 in the issue) already has the include — this brings the desktop demo in line.
Single-line, JSON-valid edit (the notebook still parses cleanly with
json.load).