Skip to content

fix: include <sstream> in audio cell of demo notebook#481

Merged
JohanMabille merged 1 commit intocompiler-research:mainfrom
mvanhorn:osc/480-add-sstream
Apr 27, 2026
Merged

fix: include <sstream> in audio cell of demo notebook#481
JohanMabille merged 1 commit intocompiler-research:mainfrom
mvanhorn:osc/480-add-sstream

Conversation

@mvanhorn
Copy link
Copy Markdown
Contributor

Closes #480.

Adds #include <sstream> to the audio cell of test/Notebooks/xeus-cpp.ipynb. The cell uses std::stringstream (au::audio::m_buffer) without the corresponding header, so toolchains that don't transitively include <sstream> via <string>/<fstream> fail to compile the cell, which is what produced the failure in #480.

The companion wasm demo notebook (referenced by @anutosh491 in the issue) already has the include — this brings the desktop demo in line.

Single-line, JSON-valid edit (the notebook still parses cleanly with json.load).

The demo notebook's audio cell uses std::stringstream but does not
include <sstream>. Some toolchains failed to compile the cell as a
result. The wasm demo notebook already includes it.

Closes compiler-research#480.
Copy link
Copy Markdown
Collaborator

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.51%. Comparing base (88a82c5) to head (0d90f4d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   74.25%   73.51%   -0.74%     
==========================================
  Files          23       23              
  Lines        1301     1193     -108     
  Branches      111      111              
==========================================
- Hits          966      877      -89     
+ Misses        335      316      -19     

see 16 files with indirect coverage changes
see 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JohanMabille JohanMabille merged commit 58d6174 into compiler-research:main Apr 27, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running cell 15 from xeus-cpp.ipynb demo notebook fails

3 participants