Skip to content

fix: issue #2495#2664

Open
michalismeng wants to merge 1 commit intocodex-team:nextfrom
michalismeng:fix/readonly-placeholder
Open

fix: issue #2495#2664
michalismeng wants to merge 1 commit intocodex-team:nextfrom
michalismeng:fix/readonly-placeholder

Conversation

@michalismeng
Copy link
Copy Markdown

Fix issue #2495.

Changes:

  • Add a default block only when a placeholder is defined.
  • In renderer, inserting an empty block when zero blocks are given, results in an extra block being rendered. In readonly mode this is empty. Fix this behavior.

Outcome of this PR:

  • Display the placeholder text, only if defined (whether in readonly mode or not).
  • Do not add an extra empty paragraph in readonly mode.

When in readonly mode, render the placeholder only if it is defined.

In addition, do not add an extra default block. Update initialization.cy.ts
accordingly for this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant