Skip to content

Fix extraneous room key in WCIF PATCH payload#76

Open
Copilot wants to merge 4 commits intomainfrom
copilot/fix-payload-extraneous-keys
Open

Fix extraneous room key in WCIF PATCH payload#76
Copilot wants to merge 4 commits intomainfrom
copilot/fix-payload-extraneous-keys

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 1, 2026

  • Identified root cause: updateRoundActivities reducer stores ActivityWithRoom objects (with room property) directly into WCIF state, causing invalid WCIF schema when sent to the API
  • Fixed updateRoundActivities reducer to strip room (and any other extraneous) properties when storing activities into WCIF
  • Updated existing test and added regression test for the room stripping
  • Fixed pre-existing test failure in actions.test.ts (always-send-version)
  • Fixed CI: lint.yml and type-check.yml were pinning node-version: '18', but @vitejs/plugin-react@5.1.2 requires ^20.19.0 || >=22.12.0. Updated both to use node-version-file: '.nvmrc' (consistent with test.yml)
  • All 350 tests passing, lint clean, typecheck clean

Copilot AI changed the title [WIP] Fix extraneous keys in payload sent to PATCH endpoint Fix extraneous room key in WCIF PATCH payload May 1, 2026
Copilot finished work on behalf of coder13 May 1, 2026 14:58
Copilot AI requested a review from coder13 May 1, 2026 14:58
@coder13 coder13 marked this pull request as ready for review May 1, 2026 15:42
@coder13
Copy link
Copy Markdown
Owner

coder13 commented May 1, 2026

@copilot fix lint and typecheck issues

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 1, 2026

@copilot fix lint and typecheck issues

The CI failures were caused by lint.yml and type-check.yml hard-coding node-version: '18', but @vitejs/plugin-react@5.1.2 requires Node ^20.19.0 || >=22.12.0. Updated both workflows to use node-version-file: '.nvmrc' (consistent with test.yml) in commit a7dfbc8.

Copilot finished work on behalf of coder13 May 1, 2026 15:47
Copilot AI requested a review from coder13 May 1, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Payload sent to main website PATCH endpoint contains extraneous keys

2 participants