Fix Tom Select timing issues in meeting_spec.rb#2597
Open
mroderick wants to merge 1 commit intocodebar:masterfrom
Open
Fix Tom Select timing issues in meeting_spec.rb#2597mroderick wants to merge 1 commit intocodebar:masterfrom
mroderick wants to merge 1 commit intocodebar:masterfrom
Conversation
The meeting edit page wasn't initializing Tom Select automatically. Added a helper method to manually initialize TomSelect if it hasn't been initialized within 2 seconds of page load. Also fixed: - Longer wait times for TomSelect initialization (10s) - JavaScript click for dropdown options to avoid element interception - Explicit waits for items to be present before trying to remove them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the flaky Tom Select tests in meeting_spec.rb.
Problem
The meeting edit page wasn't initializing Tom Select automatically, causing tests to fail with:
Solution
ensure_tom_select_initializedhelper method that manually initializes TomSelect if it hasn't been initialized within 2 secondsTests Fixed