Skip to content

Handle HTTPS_PROXY in http.Transport#22

Closed
David Courtey (David-Crty) wants to merge 3 commits intocloudposse:mainfrom
David-Crty:handle-proxy
Closed

Handle HTTPS_PROXY in http.Transport#22
David Courtey (David-Crty) wants to merge 3 commits intocloudposse:mainfrom
David-Crty:handle-proxy

Conversation

@David-Crty
Copy link
Copy Markdown

what

  • Adding the possibility to properly handle the HTTPS_PROXY env var

why

  • In some infra context the remote GitHub endpoint (eg: api.github.com is accessible only through a remote proxy)
  • Currently if you set HTTPS_PROXY, the variable is ignored

references

Let me know if can do more to get this feature merged

@David-Crty David Courtey (David-Crty) requested a review from a team as a code owner July 11, 2023 11:34
Comment thread main.go Outdated
Co-authored-by: Igor Rodionov  <goruha@gmail.com>
@David-Crty
Copy link
Copy Markdown
Author

David Courtey (David-Crty) commented Sep 19, 2025

I have implemented the change, Igor Rodionov (@goruha).

@David-Crty
Copy link
Copy Markdown
Author

No response so I will close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants