Made changes for BUG #141#149
Open
anantguptadbl wants to merge 1 commit intoclips:masterfrom
anantguptadbl:master
Open
Made changes for BUG #141#149anantguptadbl wants to merge 1 commit intoclips:masterfrom anantguptadbl:master
anantguptadbl wants to merge 1 commit intoclips:masterfrom
anantguptadbl:master
Conversation
Signed-off-by: anantguptadbl <anantguptadbl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anantguptadbl anantguptadbl@gmail.com
The way the singularize function is structured, it was creating issues for few words that appear at the end of large words
Within the function there were specific calls for endswith
For the words listed in
singular_irregular
singular_uncountable
singular_uninflected
the above is changed to
The function endswith will not add value, so I replaced it with a simple equals comparison