Fixing Issue#141: singular forms of words ending in 'our' and in 'lives'#142
Open
emilhdiaz wants to merge 1 commit intoclips:masterfrom
chicory:issue#141
Open
Fixing Issue#141: singular forms of words ending in 'our' and in 'lives'#142emilhdiaz wants to merge 1 commit intoclips:masterfrom chicory:issue#141
emilhdiaz wants to merge 1 commit intoclips:masterfrom
chicory:issue#141
Conversation
emilhdiaz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule
'our': 'my'in singular_irregular was causing many words that end in 'our' (flour, your, sour, colour, etc...) to be incorrectly singularized. This change moves 'our' -> 'my' into a new special list of singular_pronouns so that separate logic can handle these cases.The rule
(r"([nlw]i)ves$" , "\\1fe" ),in singular_rules was causing words that end in 'lives' (olives, etc..) to be incorrectly singularized. The rule is still necessary for the word 'lives' itself but a new rule with higher precedence was added to handle the case of words ending in 'lives'.