S singular fix#132
Open
jonmcoe wants to merge 9 commits intoclips:masterfrom
Open
Conversation
added 8 commits
October 18, 2015 13:10
… spacing approach
michael-k
reviewed
Jul 21, 2017
| if w.endswith(x+"s"): | ||
| return w | ||
| prefix = w[:w.find(x)] | ||
| return prefix+x |
There was a problem hiding this comment.
- I think it should have returned
wordand notw - Isn't
prefix = word[:w.find(x)]; return prefix+xjust a complex version ofreturn word[:-1]?
Author
There was a problem hiding this comment.
sure, will change. i thought it captured the idea better (see how its exact same code at both sections you commented), more readable, etc. but your suggestion is def more concise and will run a bit faster
michael-k
reviewed
Jul 21, 2017
| for x in singular_s: | ||
| if w.endswith(x+"es"): | ||
| prefix = w[:w.find(x)] | ||
| return prefix+x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change to logic for pluralization, singularization of some special groups
a few changes/additions to these groups
more tests