Skip to content

Fix for cardinal number odditity #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abcht wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix for cardinal number odditity #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab15241
Fix for bounty https://github.com/clips/pattern/issues/84
abcht Sep 25, 2015
cb68312
Update test_en.py
abcht Sep 25, 2015
95aa083
Removed redundant assertion
abcht Sep 25, 2015
530ab28
Merge branch 'master' of github.com:abcht/pattern
abcht Sep 25, 2015
84f03ca
Removed pdb statement
abcht Oct 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pattern/text/en/en-lexicon.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ $25 CD
17 CD
17th CD
1st JJ
2 IN
2 CD
20 CD
2008 CD
2010 CD
Expand All @@ -443,7 +443,7 @@ $25 CD
3 CD
30 CD
31 CD
4 IN
4 CD
40 CD
48 CD
4th CD
Expand Down
10 changes: 10 additions & 0 deletions test/test_en.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,16 @@ def test_parsetree(self):
self.assertTrue(isinstance(v, en.Text))
print("pattern.en.parsetree()")

def test_parsetree_cardinal_number(self):
""" Test that it correctly identified numbers as Cardinal Numbers
"""
for test_num in xrange(0, 10):
test_num = str(test_num)
v = en.parsetree("I am %s years old" % test_num)
found_num = v.words[2]
self.assertEquals(found_num.type, 'CD')
self.assertEquals(found_num.string, test_num)

def test_split(self):
# Assert split(parse(s)) == Text.
v = en.split(en.parse("The cat purs."))
Expand Down