fix(express): forward all auth options to authenticateRequest#8370
Draft
jacekradko wants to merge 1 commit intomainfrom
Draft
fix(express): forward all auth options to authenticateRequest#8370jacekradko wants to merge 1 commit intomainfrom
jacekradko wants to merge 1 commit intomainfrom
Conversation
Spread the full options object through to clerkClient.authenticateRequest() instead of re-destructuring a hand-picked subset. This closes the class of bug where fields accepted by the ClerkMiddlewareOptions type (e.g. organizationSyncOptions, skipJwksCache, headerType) were silently ignored at runtime — same shape as the clockSkewInMs issue fixed in #8287. Middleware-only keys (clerkClient, debug, frontendApiProxy) are peeled off so they don't leak into the backend call.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ab71710 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #8287. That PR fixed
clockSkewInMsbeing silently dropped in@clerk/express's middleware. This addresses the class of bug — not just that one field.packages/express/src/authenticateRequest.tswas re-destructuring a hand-picked subset ofClerkMiddlewareOptions(=AuthenticateRequestOptions & VerifyTokenOptions) and passing only those fields toclerkClient.authenticateRequest(). Everything not explicitly listed was accepted by the TypeScript types and silently ignored at runtime. Fields that were still being dropped:AuthenticateRequestOptions:organizationSyncOptions,signUpUrl,afterSignInUrl,afterSignUpUrl,satelliteAutoSyncVerifyJwtOptions:headerTypeLoadClerkJWKFromRemoteOptions:skipJwksCache,apiUrl,apiVersionApproach
Spread the full
optionsobject through toclerkClient.authenticateRequest(), peeling off:clerkClient,debug,frontendApiProxy)isSatellite,domain,signInUrl,proxyUrl,secretKey,machineSecretKey,publishableKey), which are then re-applied after resolutionNew options added to
AuthenticateRequestOptions/VerifyTokenOptionsin the future flow through without another edit here.Scope notes
session.getToken()returning a 20h-stale JWT on the client — that's unrelated to the middleware option plumbing (20h is far beyond anyclockSkewInMsvalue).ClerkMiddlewareOptionsshould be narrowed at the type level instead (so middleware-only keys don't structurally overlap withAuthenticateRequestOptionsin the first place). Happy to take that on in this PR if preferred.Test plan
AuthenticateRequestOptions/VerifyTokenOptions(organizationSyncOptions, skipJwksCache, headerType, audience, authorizedParties, jwtKey, acceptsToken) are forwarded