Skip to content

Default to root package when pnpm-workspace.yaml is missing a packages field #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andarist merged 1 commit into from
May 8, 2026
Merged

Default to root package when pnpm-workspace.yaml is missing a packages field #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions get-changed-packages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,12 @@ export const getChangedPackages = async ({
const pnpmWorkspaceContent = await fetchTextFile("pnpm-workspace.yaml");
const pnpmWorkspace = safeLoad(pnpmWorkspaceContent) as PnpmWorkspace;

tool = {
tool: "pnpm",
globs: pnpmWorkspace.packages,
};
if (pnpmWorkspace.packages) {
tool = {
tool: "pnpm",
globs: pnpmWorkspace.packages,
};
}
} else {
const rootPackageJsonContent = await rootPackageJsonContentsPromise;

Expand Down
53 changes: 53 additions & 0 deletions test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,59 @@ thing
`);
});

it("uses the root package when pnpm-workspace.yaml has no packages defined", async ({
expect,
task,
}) => {
const probot = setupProbot(task.id);
const { requests } = usePrState(server, {
files: {
".changeset/config.json": JSON.stringify({}),
"package.json": JSON.stringify({
name: "root-package",
}),
"pnpm-workspace.yaml": "onlyBuiltDependencies:\n - esbuild\n",
"src/index.ts": [{ status: "added" }, "export {};"],
},
comments: [],
});

await probot.receive({
name: "pull_request",
payload: pullRequestOpen,
} as never);

const commentRequests = requests.filter((request) => request.path.includes("/comments"));

expect(commentRequests).toMatchInlineSnapshot(`
[
{
"body": {
"body": "### ⚠️ No Changeset found

Latest commit: c4d7edfd758bd44f7d4264fb55f6033f56d79540

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. **If these changes should result in a version bump, you need to add a changeset.**

<details><summary>This PR includes no changesets</summary>

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

</details>

[Click here to learn what changesets are, and how to add one](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md).

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/changesets/bot/new/test?filename=.changeset/<CHANGESET_FILE>.md&value=---%0A%22root-package%22%3A%20patch%0A---%0A%0Athing%0A)

",
},
"method": "POST",
"path": "/repos/changesets/bot/issues/2/comments",
},
]
`);
});

it("shows release details when a changed changeset parses into a release plan", async ({
expect,
task,
Expand Down