Use poetry instead of venv#16
Open
sethrj wants to merge 10 commits into
Open
Conversation
Replace setuptools/venv/uv workflows with Poetry-based dependency, lockfile, build, and CI integration. Assisted-by: GitHub Copilot (GPT-5.3-Codex)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the project’s packaging and development workflow from pyenv + .venv + uv pip compile lockfiles to Poetry, updating CI and build tooling accordingly.
Changes:
- Remove
requirements.txt/requirements-dev.txtand switch build metadata inpyproject.tomlto Poetry (poetry-corebackend). - Update
makefileand GitHub Actions workflows to install and run tooling viapoetry install/poetry run. - Replace setuptools_scm-based version reporting with
importlib.metadata(__version__), and update the CLI--versionpath.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.txt | Removed generated runtime lockfile in favor of Poetry. |
| requirements-dev.txt | Removed generated dev lockfile in favor of Poetry. |
| pyproject.toml | Switched build backend/metadata to Poetry; updated dependency constraints and scripting. |
| makefile | Replaced venv/pyenv/uv flows with Poetry-based install/test/build targets. |
| celerpy/cli.py | Updated version printing to use __version__. |
| celerpy/init.py | Updated __version__ resolution to use installed package metadata with fallback. |
| .python-version | Removed pinned local Python version file. |
| .gitignore | Changed to track poetry.lock. |
| .github/workflows/test.yml | CI now sets Python directly and installs Poetry before make install. |
| .github/workflows/pypi.yml | Release workflow now installs Poetry and builds via make build. |
| .github/workflows/lockfiles.yml | Replaced pip lockfile updater with poetry update + PR creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
8
to
+13
| .PHONY: install | ||
| install: $(PYENV_TARGET) $(VENV_TARGET) pip | ||
| install: poetry-install | ||
|
|
||
| .PHONY: pyenv | ||
| pyenv: | ||
| pyenv install --skip-existing $(PYTHON_VERSION) | ||
| .PHONY: poetry-install | ||
| poetry-install: | ||
| poetry install |
Comment on lines
+10
to
+17
| [tool.poetry] | ||
| authors = ["Seth R. Johnson et al."] | ||
| description = "" | ||
| license = "Apache-2.0" | ||
| name = "celerpy" | ||
| packages = [{include = "celerpy"}] | ||
| readme = "README.md" | ||
| version = "0.1.0" |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.